Skip to content

Fix 3mf export on scenes with multiple nodes with same geometry #2473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 21, 2025
Merged

Fix 3mf export on scenes with multiple nodes with same geometry #2473

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5fb88b4
Change file for 3MF round trip test
markstor Oct 21, 2025
533c6e7
Use geometry id if available
markstor Oct 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file added models/pyramids.3mf
View file
Open in desktop
Binary file not shown.
4 changes: 2 additions & 2 deletions tests/test_3mf.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,8 +57,8 @@ def test_roundtrip(self):

# test a scene round-tripped through the
# 3MF exporter and importer
s = g.get_mesh("cycloidal.3DXML")
assert len(s.geometry) == 13
s = g.get_mesh("pyramids.3mf")
assert len(s.geometry) == 6

# export and reload
r = g.trimesh.load(
Expand Down
2 changes: 1 addition & 1 deletion trimesh/exchange/threemf.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -420,7 +420,7 @@ def model_id(x):
etree.Element(
"item",
{
"objectid": model_id(node),
"objectid": model_id(data.get('geometry', node)),
"transform": transform,
uuid_tag: str(uuid.uuid4()),
},
Expand Down
Loading