Fix 3mf export on scenes with multiple nodes with same geometry #2473
+3
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great idea, thanks for the PR! With regards to the part number/id field I didn't realize they had a unique identifier in the format, it might also be cool if someday we could round-trip an export-import cycle and preserve those unique identifiers. |
Merged
mikedh
added a commit
that referenced
this pull request
Oct 22, 2025
- Be more flexible in getting unit hints from file names since it was a little silly that `20mm-xyz-cube` did not resolve as `mm`. - Apply [actions guidance](actions/runner-images#13045) updating to use the `macos-15-intel` image. - test and fix `trimesh.scene.lighting.autolight` crashing on empty scenes by checking `scene.bounds is None` - release #2470 - add a note about whether or not we should apply the fix from #2457 to `PBRMaterial.to_simple` using the same conversion function for the linear `baseColorFactor` to RGB, but don't actually apply the change as it seems likely to be a source of user confusion. - add a `Path2D.convex_hull` to match every other geometry method. - update `test_scene.py` to pytest style - release #2472 - release #2473 - Add in another `Literal` type for `VoxelizationMethodsType` rather than a "loose string".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.