Fix that Message#attachments cannot count singlepart attachment #1144
+37
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kirikak2
force-pushed
the
get_singlepart_attachments
branch
2 times, most recently
from
8fff96d to
96e7e62
Compare
kirikak2
changed the title
kirikak2
force-pushed
the
get_singlepart_attachments
branch
from
96e7e62 to
6bfef98
Compare
evaldasg
reviewed
Dec 17, 2017
| header_part << header[:content_type].encoded if header[:content_type] | ||
| header_part << header[:content_disposition].encoded if header[:content_disposition] | ||
| header_part << header[:content_transfer_encoding].encoded if header[:content_transfer_encoding] | ||
| header_part << header[:content_discription].encoded if header[:content_discription] |
There was a problem hiding this comment.
header[:content_description] typo here
|
Unfortunately, this issue is causing me problems when parsing DMARC reports coming from Google. I've tested this branch and, apart from correcting the above-mentioned typo, found that it worked without modification. @kirikak2 any chance you can get this over the line? Alternatively, I could make a new PR based on this one but compatible with the current version of mail |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see #1143