Skip to content

Conversation

@lebrice
Copy link
Collaborator

@lebrice lebrice commented Apr 2, 2025

As described in #77 and #130 , it seems like the copier command is causing some issues on MacOS (Jax cuda dependency or something similar).

Problem is, there are tests for this, but they were turned off because of issues when running the commands in the GitHub CI.

This PR does the following:

  • Turn on the tests for the copier command in the GitHub CI on MacOS
  • Fix the issues that occur when running the copier command on MacOS.

Signed-off-by: Fabrice Normandin [email protected]

@lebrice lebrice linked an issue Apr 2, 2025 that may be closed by this pull request
@lebrice lebrice marked this pull request as ready for review April 3, 2025 19:41
@lebrice lebrice force-pushed the fix_macos_issues branch from f54e59c to 09293ff Compare April 7, 2025 17:55
lebrice added 5 commits April 7, 2025 14:25
Signed-off-by: Fabrice Normandin <[email protected]>
Signed-off-by: Fabrice Normandin <[email protected]>
Signed-off-by: Fabrice Normandin <[email protected]>
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 79.31034% with 6 lines in your changes missing coverage. Please review.

Project coverage is 72.14%. Comparing base (d804a93) to head (a3fd981).

Files with missing lines Patch % Lines
project/algorithms/jax_ppo.py 85.71% 3 Missing ⚠️
project/algorithms/callbacks/samples_per_second.py 33.33% 2 Missing ⚠️
project/conftest.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #129      +/-   ##
==========================================
- Coverage   72.34%   72.14%   -0.21%     
==========================================
  Files          51       50       -1     
  Lines        3902     3877      -25     
==========================================
- Hits         2823     2797      -26     
- Misses       1079     1080       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@lebrice lebrice merged commit e190484 into master Apr 14, 2025
7 checks passed
@lebrice lebrice deleted the fix_macos_issues branch April 14, 2025 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Issues running copier command on MacOS

2 participants