Skip to content

fix: analyzer memory leak because function runner not close #41839

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 5, 2025

Conversation

aoiasd
Copy link
Contributor

@aoiasd aoiasd commented May 14, 2025

relate: #41213

@sre-ci-robot sre-ci-robot added the size/M Denotes a PR that changes 30-99 lines. label May 14, 2025
@sre-ci-robot sre-ci-robot requested review from bigsheeper and czs007 May 14, 2025 11:13
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels May 14, 2025
@aoiasd aoiasd changed the title fix: analyzer memroy leak because function runner not close fix: analyzer memory leak because function runner not close May 14, 2025
Copy link
Contributor

mergify bot commented May 14, 2025

@aoiasd cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

sre-ci-robot pushed a commit that referenced this pull request May 15, 2025
@aoiasd aoiasd force-pushed the C16 branch 2 times, most recently from 0c281c4 to 331be0c Compare May 16, 2025 06:59
Copy link

codecov bot commented May 16, 2025

Codecov Report

Attention: Patch coverage is 66.66667% with 6 lines in your changes missing coverage. Please review.

Project coverage is 80.47%. Comparing base (020d366) to head (389e986).
Report is 35 commits behind head on master.

Files with missing lines Patch % Lines
...rnal/util/function/multi_analyzer_bm25_function.go 0.00% 4 Missing ⚠️
internal/datanode/importv2/util.go 0.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #41839      +/-   ##
==========================================
- Coverage   80.48%   80.47%   -0.01%     
==========================================
  Files        1538     1538              
  Lines      218517   218535      +18     
==========================================
+ Hits       175871   175874       +3     
- Misses      36303    36315      +12     
- Partials     6343     6346       +3     
Components Coverage Δ
Client 79.36% <ø> (ø)
Core 72.99% <ø> (ø)
Go 81.94% <66.66%> (-0.01%) ⬇️
Files with missing lines Coverage Δ
.../flushcommon/pipeline/flow_graph_embedding_node.go 85.57% <100.00%> (+0.57%) ⬆️
internal/querynodev2/pipeline/embedding_node.go 90.27% <100.00%> (+0.27%) ⬆️
internal/util/function/bm25_function.go 76.87% <100.00%> (+0.27%) ⬆️
internal/util/function/function.go 100.00% <ø> (ø)
internal/util/pipeline/node.go 100.00% <100.00%> (ø)
internal/util/pipeline/pipeline.go 88.37% <100.00%> (+0.27%) ⬆️
internal/datanode/importv2/util.go 72.20% <0.00%> (-0.40%) ⬇️
...rnal/util/function/multi_analyzer_bm25_function.go 63.96% <0.00%> (-1.18%) ⬇️

... and 34 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

mergify bot commented May 27, 2025

@aoiasd E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

1 similar comment
Copy link
Contributor

mergify bot commented May 28, 2025

@aoiasd E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

mergify bot commented May 28, 2025

@aoiasd cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

Copy link
Contributor

mergify bot commented May 29, 2025

@aoiasd E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@aoiasd
Copy link
Contributor Author

aoiasd commented May 30, 2025

/run-cpu-e2e

@mergify mergify bot added the ci-passed label May 30, 2025
Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aoiasd, congqixia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 2eb24fb into milvus-io:master Jun 5, 2025
18 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants