Skip to content

Removes some erroneous config options for webhook #1444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 1, 2025
Merged

Removes some erroneous config options for webhook #1444

merged 1 commit into from
Apr 1, 2025

Conversation

djwfyi
Copy link
Collaborator

@djwfyi djwfyi commented Apr 1, 2025

Closes #1434

These config options were likely a copy/paste error from other target types.
Refer to https://github.com/minio/minio/blob/master/internal/event/target/webhook.go#L64-L73 for the correct list.
This update matches that code.

@djwfyi djwfyi requested review from feorlen and Bradamant3 April 1, 2025 19:28
@djwfyi djwfyi self-assigned this Apr 1, 2025
Copy link
Collaborator

@Bradamant3 Bradamant3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@djwfyi djwfyi merged commit 8969abd into main Apr 1, 2025
1 check passed
@djwfyi djwfyi deleted the webhook branch April 1, 2025 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't set NOTIFY_WEBHOOK - MAX_RETRY
2 participants