Skip to content

[MAN-2071] Add alert banner for acceptable absense#1517

Merged
anandelangovan1 merged 7 commits into
mainfrom
MAN-2071
Jun 5, 2026
Merged

[MAN-2071] Add alert banner for acceptable absense#1517
anandelangovan1 merged 7 commits into
mainfrom
MAN-2071

Conversation

@anandelangovan1

Copy link
Copy Markdown
Contributor

No description provided.

@anandelangovan1 anandelangovan1 force-pushed the MAN-2071 branch 4 times, most recently from c1699e9 to 29ee307 Compare June 4, 2026 09:50
@Luca2471 Luca2471 requested a review from Copilot June 4, 2026 12:18

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds “multiple acceptable absences” alerting to the acceptable-absence appointment outcome page by wiring MAS compliance data into the journey and extending Wiremock/test fixtures to exercise the new behaviour.

Changes:

  • Fetch and expose acceptableAbsenceCount from MAS compliance data and render a new alert panel when count > 1.
  • Update domain models and middleware/unit/e2e tests to include and verify acceptable absence counts.
  • Extend Wiremock mappings/stubs to return acceptable absence data and counts.

Reviewed changes

Copilot reviewed 17 out of 17 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
wiremock/stubs/compliance.ts Adds acceptableAbsenceCount to the compliance stubbed response used in e2e.
wiremock/mappings/X778160-non-compliance-detail.json Adds a sample acceptable absence entry in non-compliance detail response.
wiremock/mappings/X778160-compliance.json Adds acceptableAbsenceCount to sentence activity counts.
wiremock/mappings/X778160-compliance-detail.json Adds acceptableAbsenceCount to sentence activity counts in the detail mapping.
wiremock/mappings/X777916-compliance.json Adds acceptableAbsenceCount to sentence activity counts.
wiremock/mappings/X000001-non-compliance-detail.json Adds a sample acceptable absence entry in non-compliance detail response.
wiremock/mappings/X000001-compliance.json Adds acceptableAbsenceCount and a second compliance mapping for months=12.
server/views/pages/appointment-outcomes/acceptable-absence.njk Renders a new alert/ticket panel when multiple acceptable absences are present.
server/routes/appointmentOutcomes.ts Wires getComplianceData into the acceptable-absence route.
server/middleware/appointment-outcomes/getComplianceData.ts Maps MAS compliance activity acceptableAbsenceCount into res.locals.appointmentOutcome.compliance.
server/middleware/appointment-outcomes/getComplianceData.test.ts Updates assertions/fixtures to include acceptableAbsenceCount.
server/middleware/appointment-outcomes/getBreach.test.ts Updates sentence compliance fixture to include the new activity count.
server/middleware/appointment-outcomes/buildCompliance.ts Adds acceptableAbsenceCount to the composed compliance object.
server/middleware/appointment-outcomes/buildCompliance.test.ts Updates fixtures/expectations to include acceptableAbsenceCount.
server/data/model/overview.ts Extends ActivityCount and Compliance interfaces with acceptable absence count fields.
server/controllers/appointmentOutcomes.test.ts Adds a controller test to ensure acceptable-absence renders without MAS calls when no selected sentence is present.
integration_tests/e2e/appointmentOutcomes/acceptable-absence.cy.ts Adds Cypress coverage for the new alert banner and link.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread server/views/pages/appointment-outcomes/acceptable-absence.njk
Comment thread server/middleware/appointment-outcomes/getComplianceData.ts
Comment thread wiremock/mappings/X000001-compliance.json
[MAN-2071] Update failing tests

[MAN-2071] Add alerting integration tests

[MAN-2071] Add alerting integration tests

[MAN-2071] Add alerting integration tests

[MAN-2071] WIP - need add test for non compliance link check

[MAN-2071] WIP - tests passing

[MAN-2071] Address review comments
@anandelangovan1 anandelangovan1 marked this pull request as ready for review June 5, 2026 12:40
@anandelangovan1 anandelangovan1 requested a review from a team as a code owner June 5, 2026 12:40
@anandelangovan1 anandelangovan1 merged commit 2a3d0f3 into main Jun 5, 2026
13 checks passed
@anandelangovan1 anandelangovan1 deleted the MAN-2071 branch June 5, 2026 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants