fix: Argument type only uses scalar and ignore list #327
Conversation
There was a problem hiding this comment.
Hi,
i think you put up a neat solution. It seems like you did not get to run you code, because there would be a syntax error.
I commented a solution in the line with the error.
Furthermore, a similar problem which is fixed #347 is also missing here.
| used_custom_scalar: Optional[str], | ||
| ) -> None: | ||
| """Accumulates return arguments.""" | ||
| constant_value = f"{final_type.name}!" if is_required else final_type.name | ||
| constant_value = self._generate_complete_type_name(complete_type) |
There was a problem hiding this comment.
this would cause a syntax error. the variable complete_type does not seem to be defined. I think you can drop the parameter final_type and put your new parameter complete_type there, then in generate_arguments() you pass complete_type=arg_value.type to _accumulate_return_arguments().
There was a problem hiding this comment.
Indeed I must have messed up with my git client. My local code is exactly what you describe. I'll push a new commit
This should fix #321
I'm not completely sure all GraphQL Types are correctly handled
I will check if I can provide tests for this if needed