better handle list types

[matthew-emw]

where our GraphQL schema has a list field as follows:

accounts(
    # ...
    """sort the rows by one or more columns"""
    order_by: [accounts_order_by!]
    # ...
  )

we were observing generated code with non-list arguments like:

def accounts(
        cls,
        *,
        # ...
        order_by: Optional[accounts_order_by] = None,
        # ...
    )

this is pehaps related to issue #321 and PR #327.

my PR reworks this to result in:

def accounts(
        cls,
        *,
        # ...
        order_by: Optional[List[accounts_order_by]] = None,
        # ...
    )

i'd like to extend my PR with tests, but:

• i see ArgumentGenerator is currently not covered by any tests
• in custom_operations.py i see both an ArgumentsGenerator being injected and an ArgumentGenerator (no ess) being instantiated
• does this imply a direction of travel and that ArgumentsGenerator should be used going forward?

i'd be grateful for any guidance. thanks!

[normanre]

Hi,

i have the same issue and have fixed it myself.

I think your solution wont work only because of #321.
When you add the solution from #327 your solution would be perfect.

Furthermore, the solution in #327 does have an syntax error. I commented a solution in #327.

[normanre]

this will not work for this type of fields [String!]! (see #321)