Skip to content

Looping: mention seconds fallback in case track has no beats - #630

Merged
Swiftb0y merged 1 commit into
mixxxdj:2.5from
ronso0:beats-seconds
Sep 17, 2025
Merged

Looping: mention seconds fallback in case track has no beats#630
Swiftb0y merged 1 commit into
mixxxdj:2.5from
ronso0:beats-seconds

Conversation

@ronso0

@ronso0 ronso0 commented Mar 22, 2024

Copy link
Copy Markdown
Member

Documentation for new seconds fallback if track has no beats.
mixxxdj/mixxx#12961

@ronso0
ronso0 changed the base branch from 2.4 to 2.5 September 17, 2025 11:46
@ronso0
ronso0 force-pushed the beats-seconds branch 2 times, most recently from fb60ab1 to 4a72f23 Compare September 17, 2025 12:02
@Swiftb0y

Copy link
Copy Markdown
Member

If the loaded track has no beats, the unit is seconds.

This is quite short and somewhat ambiguous. I would propose

If the loaded track has no beat grid, this value is treated as seconds instead of beats.

I know we technically make a distinction between beat grid and beat map, but I don't think thats user facing and most users don't care about the difference and just know it as beat grid (even if its a variable beat map under the hood).

@ronso0

ronso0 commented Sep 17, 2025

Copy link
Copy Markdown
Member Author

Updated, and I also included beatjump.

@Swiftb0y Swiftb0y left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you.

@Swiftb0y
Swiftb0y merged commit 7053d8e into mixxxdj:2.5 Sep 17, 2025
9 checks passed
@ronso0
ronso0 deleted the beats-seconds branch September 17, 2025 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants