Skip to content

Fix clicks at loop-out when looping into lead-in - #13294

Merged
ronso0 merged 2 commits into
mixxxdj:2.4from
daschuer:loop_leadin_fade
Jun 20, 2024
Merged

Fix clicks at loop-out when looping into lead-in#13294
ronso0 merged 2 commits into
mixxxdj:2.4from
daschuer:loop_leadin_fade

Conversation

@daschuer

Copy link
Copy Markdown
Member

This fixes a regression from f0870ff

@ronso0

ronso0 commented May 26, 2024

Copy link
Copy Markdown
Member

Can you please provide steps to reproduce/check the fix?

Here's a commit with a comment, and another small tweak
7570cda

@daschuer

daschuer commented Jun 9, 2024

Copy link
Copy Markdown
Member Author

Here is the receipt to reproduce.

  • Use a monotone test track like a 440 Hz sine tone.
  • Create a loop starting at lead in
    -> hear the click sound at loop out. You may also record it and look at it using audacity

With this PR applied the click is smoothed out.

@ronso0

ronso0 commented Jun 20, 2024

Copy link
Copy Markdown
Member

I don't hear the clicks tbh, but I see the fading to zero.
LGTM, thanks!

@ronso0
ronso0 merged commit 985b121 into mixxxdj:2.4 Jun 20, 2024
@daschuer
daschuer deleted the loop_leadin_fade branch April 24, 2025 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants