Skip to content

Fix clicks at loop-out when looping into lead-in #13294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ronso0 merged 2 commits into from
Jun 20, 2024
Merged

Fix clicks at loop-out when looping into lead-in #13294

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7e56d0a
Fade out loop end even if we loop into pre-roll and have no samples c…
daschuer May 26, 2024
6e8681d
fade out: add comment
ronso0 May 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion src/engine/readaheadmanager.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,10 @@ SINT ReadAheadManager::getNextSamples(double dRate, CSAMPLE* pOutput,
// Previous read was a cache miss, but now we got something back.
// Apply ramping gain, because the last buffer has unwanted silence
// and new samples without fading are causing a pop.
SampleUtil::applyRampingGain(pOutput, 0.0, 1.0, samples_from_reader);
SampleUtil::applyRampingGain(pOutput,
CSAMPLE_GAIN_ZERO,
CSAMPLE_GAIN_ONE,
samples_from_reader);
// Reset the cache miss flag, because we are now back on track.
m_cacheMissHappened = false;
}
Expand Down Expand Up @@ -186,6 +189,12 @@ SINT ReadAheadManager::getNextSamples(double dRate, CSAMPLE* pOutput,
m_pCrossFadeBuffer,
crossFadeSamples);
}
} else {
// No samples for crossfading, ramp to zero
SampleUtil::applyRampingGain(pOutput,
CSAMPLE_GAIN_ONE,
CSAMPLE_GAIN_ZERO,
samples_from_reader);
}
}

Expand Down