(fix) Track file export: various fixes - #13610
Merged
Merged
Conversation
ronso0
force-pushed
the
track-export-skip-fix
branch
from
August 29, 2024 13:52
37520b3 to
c858211
Compare
Member
|
In the corresponding Nemo File Manager dialog we have checkbox for all files and only three buttons. |
daschuer
requested changes
Aug 30, 2024
daschuer
left a comment
daschuer
left a comment
Member
There was a problem hiding this comment.
After fixing the build it works here. I will file a feature request for the checkbox.
| } | ||
|
|
||
| void CrateFeature::slotExportTrackFiles() { | ||
| m_lastRightClickedIndex = index; |
Member
There was a problem hiding this comment.
How does this work? What is index?
Member
Author
There was a problem hiding this comment.
umm 🤷
I made the fix in 2.5, build, then rebased onto 2.4 but didn't build again, so my guess is this is a wronlgy resolved conflict.
Interesting that CI can build it.
ronso0
force-pushed
the
track-export-skip-fix
branch
from
August 30, 2024 14:41
c858211 to
9848391
Compare
ronso0
marked this pull request as draft
August 30, 2024 15:40
ronso0
force-pushed
the
track-export-skip-fix
branch
from
August 30, 2024 15:54
9848391 to
2d4dfe3
Compare
ronso0
marked this pull request as ready for review
August 30, 2024 15:54
daschuer
reviewed
Aug 30, 2024
| question_box.setDefaultButton(pSkip); | ||
|
|
||
| question_box.exec(); | ||
| auto pBtn = question_box.clickedButton(); |
Member
There was a problem hiding this comment.
clang-tidy is suggesting:
Suggested change
| auto pBtn = question_box.clickedButton(); | |
| auto* pBtn = question_box.clickedButton(); |
ronso0
force-pushed
the
track-export-skip-fix
branch
from
August 30, 2024 17:28
2d4dfe3 to
66ec8b4
Compare
Swiftb0y
reviewed
Aug 30, 2024
ronso0
force-pushed
the
track-export-skip-fix
branch
from
August 31, 2024 12:48
66ec8b4 to
ece92f1
Compare
Swiftb0y
approved these changes
Aug 31, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The overwrite dialog had confusing/duplicate buttons,and clicking Skip would cancel the dialog
before:
now:
Crate: use the right-clicked carte (no the selected crate, which might be null)
abort track export if no tracks are selected (empty crate/playlist), previously the progress dialog would be empty and remain open forever