Track File Export: add 'Apply to all' checkbox, remove ".. All" buttons - #13614
Merged
acolombier merged 1 commit intoFeb 21, 2025
Merged
Conversation
Member
|
Uh that was quick. Thank you. The new texts will likely be untranslated in a 2.5 release, so let's keep this for 2.6. |
ronso0
force-pushed
the
track-export-apply-to-all-checkbox
branch
from
September 6, 2024 22:21
1392b33 to
c772e6f
Compare
ronso0
marked this pull request as ready for review
September 6, 2024 22:22
ywwg
reviewed
Dec 13, 2024
acolombier
reviewed
Feb 18, 2025
Member
Author
|
Thanks for your review! |
acolombier
approved these changes
Feb 20, 2025
acolombier
left a comment
acolombier
left a comment
Member
There was a problem hiding this comment.
LGTM! I'm tempted to try the /softfix command but scared to make a mess...
Member
Author
|
/softfix |
Member
Author
|
Well, let's see... |
github-actions
Bot
force-pushed
the
track-export-apply-to-all-checkbox
branch
from
February 20, 2025 23:51
4f74655 to
cb67dbe
Compare
Member
Author
|
Looking good! 🎉 |
Member
Author
|
Though CI hasn't been triggered (clazy was still running when I use softfix) |
Member
Ah yeah, this is because we are using the default github token ( Edit: created #14386 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
based on #13610, so it's only the last commit 1392b33
Looks like this now:
new tr strings:
Replace
Apply to all files
(if you like I can rebase onto 2.5)
Fixes #13613