Skip to content

Track File Export: add 'Apply to all' checkbox, remove ".. All" buttons #13614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
acolombier merged 1 commit into from
Feb 21, 2025
Merged

Track File Export: add 'Apply to all' checkbox, remove ".. All" buttons #13614

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 16 additions & 14 deletions src/library/export/trackexportdlg.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
#include "library/export/trackexportdlg.h"

#include <QCheckBox>
#include <QMessageBox>

#include "moc_trackexportdlg.cpp"
Expand Down Expand Up @@ -66,30 +67,31 @@ void TrackExportDlg::slotAskOverwriteMode(
std::promise<TrackExportWorker::OverwriteAnswer>* promise) {
QMessageBox question_box(
QMessageBox::Warning,
tr("Overwrite Existing File?"),
tr("\"%1\" already exists, overwrite?").arg(filename),
QMessageBox::Cancel);
tr("Replace Existing File?"),
tr("\"%1\" already exists, replace?").arg(filename),
QMessageBox::Cancel,
this);

QPushButton* pSkip = question_box.addButton(
tr("&Skip"), QMessageBox::NoRole);
QPushButton* pSkipAll = question_box.addButton(
tr("Skip &All"), QMessageBox::NoRole);
QPushButton* pOverwrite = question_box.addButton(
tr("&Overwrite"), QMessageBox::YesRole);
QPushButton* pOverwriteAll = question_box.addButton(
tr("Over&write All"), QMessageBox::YesRole);
tr("&Replace"), QMessageBox::YesRole);
question_box.setDefaultButton(pSkip);

QCheckBox* pApplyToAll = new QCheckBox(tr("Apply to all files"));
Comment thread
acolombier marked this conversation as resolved.
pApplyToAll->setChecked(false);
question_box.setCheckBox(pApplyToAll);

question_box.exec();
auto* pBtn = question_box.clickedButton();
if (pBtn == pSkip) {
promise->set_value(TrackExportWorker::OverwriteAnswer::SKIP);
} else if (pBtn == pSkipAll) {
promise->set_value(TrackExportWorker::OverwriteAnswer::SKIP_ALL);
promise->set_value(pApplyToAll->isChecked()
? TrackExportWorker::OverwriteAnswer::SKIP_ALL
: TrackExportWorker::OverwriteAnswer::SKIP);
} else if (pBtn == pOverwrite) {
promise->set_value(TrackExportWorker::OverwriteAnswer::OVERWRITE);
} else if (pBtn == pOverwriteAll) {
promise->set_value(TrackExportWorker::OverwriteAnswer::OVERWRITE_ALL);
promise->set_value(pApplyToAll->isChecked()
? TrackExportWorker::OverwriteAnswer::OVERWRITE_ALL
: TrackExportWorker::OverwriteAnswer::OVERWRITE);
} else {
// Cancel
promise->set_value(TrackExportWorker::OverwriteAnswer::CANCEL);
Expand Down