[GSoC] LateNightQML: Deck (part 2) by xARSENICx · Pull Request #16691 · mixxxdj/mixxx

xARSENICx · 2026-07-05T18:51:55Z

This PR continues the LateNightQML deck work after Deck (part 1), focusing on the remaining deck waveform, overview, track metadata actions, vinyl/pass visuals, and rate-control polish for both the Classic and PaleMoon color schemes.

Testing the Experimental Skin

Since this is an early experimental milestone, you must first run Mixxx with the developer flag:

./build/mixxx --developer

Once Mixxx is open, switch to the experimental skin:
Preferences -> Interface -> LateNight QML (Experimental)

You can dynamically toggle between the Classic and PaleMoon color schemes under preferences.

Previews

Classic

PaleMoon

Scope of Changes

Implemented in this PR:

Deck Track Actions: Track title/artist fields now support deck track context menu and properties actions through QML.
Waveforms & Overview: Adds LateNightQML waveform display styling, beatgrid controls, waveform marker rendering, and overview marker/range overlays.
Vinyl & Rate Polish: Restores LateNight-style vinyl/pass button fills and text states, keeps vinyl/pass requests routed through engine controls, and fixes clipped rate-range labels.

Note:

Hotcue and loop deck control functionality has been removed from this branch for now and will be restored in a later commit or follow-up PR.

Tracking

GSoC: LateNightQML PR-6

ronso0 · 2026-07-06T10:26:05Z

Just a note - not sure when it started nor whether this is related to running Mixxx QML in VirtualBox:
My log is spammed with these lines

debug [Main] Processing QEvent::Timer for object 0x6371a673c060 took 18 ms
debug [Main] Processing QEvent::UpdateRequest for object ApplicationWindow_QMLTYPE_131_QML_146(0x6371a673c060) running in thread: "Main" took 25 ms

Log spam frequency increases otably as soon as I load a track into a deck.

And the EDIT mode (dnd to rearrange UI elements) doesn't work anymore.

xARSENICx · 2026-07-06T15:14:02Z

The log spam comes from MixxxApplication::notify() slow-event logging in developer mode, not from a specific LateNightQML qDebug IIRC.

the EDIT mode (dnd to rearrange UI elements) doesn't work anymore.

Yeah, it is not being introduced as of now.

JoergAtGithub · 2026-07-07T22:02:21Z

the EDIT mode (dnd to rearrange UI elements) doesn't work anymore.

Yeah, it is not being introduced as of now.

It's definetally a nice feature, but somehow we need to restrict the scope, so that we can deliver a complete product at the end of the project that doesn't have any significant functionality gaps.

JoergAtGithub · 2026-07-19T09:41:34Z

+    }
+
+    function handleTapClick(mouse) {
+        if (Date.now() - root.tapModeEnteredAt < root.tapModeClickGuardTimeout) {


tapModeEnteredAt should be an required property

tapModeEnteredAt is internal state set when the component enters tap mode, so making it required would add an invalid caller contract. I’ll keep it local.

I meant "readonly property" with initialization. Without initialization the outcome of
if (Date.now() - root.tapModeEnteredAt < root.tapModeClickGuardTimeout)
is random.

Understood. Since the guard is restarted whenever tap mode opens, the timestamp cannot be readonly. I replaced it with a Timer so the guard state is initialized and deterministic.

JoergAtGithub · 2026-07-19T09:43:45Z

+
+    function applyEditValueAndQuit() {
+        const parsedValue = Number(editInput.text);
+        if (!isFinite(parsedValue)) {


Number("") returns 0, not NaN, so isFinite guard does't catch empty input which result in 0.0 BPM display. Please fix and test this!

NaN, doesn't legacy display it as 0.0 too? I didn't get you

Legacy LateNight restores the original BPM value in case of an empty string. With 0.0 BPM the music would stop.

Fixed. Empty input now closes the editor without writing the control, so the original BPM or rate is preserved.

JoergAtGithub · 2026-07-19T10:13:01Z

+    id: root
+
+    required property string group
+    required property var track


Suggested change

required property var track

required property Mixxx.Track track

Always use typed vars

JoergAtGithub · 2026-07-19T11:35:29Z

-                Layout.preferredWidth: 180
+                Layout.fillHeight: true
+                group: root.group
+                track: currentTrack


Suggested change

track: currentTrack

track: root.currentTrack

JoergAtGithub · 2026-07-19T11:55:37Z

+                            width: 12
+                            height: 10
+                            text: hotcueMarker.hotcueNumber
+                            color: "#FFFFFF"


Hardcoded color values should only be used in LateNightTheme.qml
Please change this everywehere!
Despite that, the text color of hotcues depend on the hotcue color. please check the logic in existing Latenight. There is a light and dark decision logic.

acolombier · 2026-08-01T17:08:22Z

@@ -1,5 +1,6 @@
 #pragma once
 #include <QObject>
+#include <QPoint>


Why was this added? in the header file?

It's a leftover from a pointer position implementation I was checking locally. Will clean up.

acolombier · 2026-08-01T17:09:48Z

                        pixmap,
-                        endPixmap,
                        icon,
+                        endPixmap,


This change is wrong. See

mixxx/src/waveform/renderers/waveformmarkset.h

Line 14 in 545510a

struct DefaultMarkerStyle {

The previous order was correct. Did you find an issue somewhere else?

You’re right. I did not find an issue elsewhere; I mixed up the WaveformMark::create() argument order with DefaultMarkerStyle. The struct’s original order is correct, so will restore it.

This is still present

JoergAtGithub

The numeric entry field for the BPM rate is not useable for me. It close automatically before I can enter all digits of the new value.
The expected behavior is that this remains open until I confirm the value by Enter keyboard button or cancel, e.g by. ESC,

JoergAtGithub · 2026-08-09T11:06:58Z

This fix does not work for me:

Aufzeichnung.2026-08-09.130634.mp4

JoergAtGithub · 2026-08-10T19:30:47Z

Rate value editing works now, but while the BPM entry field is open, there appear wrong placed + and - rate buttons and the borders of the area llok wrong too:

Aufzeichnung.2026-08-10.212853.mp4

For comparistion, the original LateNight:

Aufzeichnung.2026-08-10.213733.mp4

Somehow the borders in the video look different than on my screen

acolombier · 2026-08-10T20:37:26Z

                        pixmap,
-                        endPixmap,
                        icon,
+                        endPixmap,


This is still present

acolombier · 2026-08-10T20:42:04Z

-    readonly property var deckPlayer: Mixxx.PlayerManager.getPlayer(root.group)
-    readonly property var currentTrack: deckPlayer?.currentTrack
+    readonly property Mixxx.Player deckPlayer: Mixxx.PlayerManager.getPlayer(root.group)
+    readonly property Mixxx.Track currentTrack: root.deckPlayer?.currentTrack


Not sure this will work because currentTrack may be null. Does this not raise any warning when this is the case?

Good point. It now explicitly falls back to null when no player or track is available, in latest commit.

acolombier · 2026-08-10T20:42:35Z

                    width: parent.width
                    height: 24
-                    text: visualBpmProxy.value.toFixed(2)
+                    text: bpmProxy.value.toFixed(2)


Where is this defined?

Here https://github.com/mixxxdj/mixxx/pull/16691/changes#diff-ac17c3b33c742a6465aedfd522985aa3bb0ecc0f5e5d7d8caf08412897b66aa8L44

acolombier · 2026-08-10T20:44:11Z

@@ -26,41 +26,12 @@ Skin.EmbeddedText {
    property double remaining: durationControl.value * (1 - playPositionControl.value)

    function toTime(value) {


What's the rational for moving this from JS to C++? Making this C++ makes customisation harder, as it requires our user to recompile Mixxx entirely.
Editing C++ also requires non trivial experience (e.g memory management, exception handling), while QML/JS is much more beginner friendly.

This was explicitly requested in Joerg’s earlier review. cc @JoergAtGithub

Lifting my change request as I will be away for a while and don't want to block merge. Please do address my comment nevertheless!

xARSENICx · 2026-08-13T12:14:28Z

#16691 (comment)

The review thread opens the old BASE..6355228 comparison, which still shows the incorrect reorder. It was restored in 815cfb2, and qmlwaveformrenderer.cpp is absent from the current all-commits Files changed view. Could you recheck the current PR diff?

xARSENICx added 3 commits July 6, 2026 00:16

feat(LateNightQML): add deck track menu actions

e6b81a0

feat(LateNightQML): add deck waveform and overview markers

de0934c

fix(LateNightQML): polish deck vinyl and rate controls

f6258b8

github-actions Bot added skins qml labels Jul 5, 2026

xARSENICx added 2 commits July 6, 2026 01:22

fix(LateNightQML): align rate range labels

c959092

feat(LateNightQML): add deck BPM tap editor

5855cca

xARSENICx force-pushed the LateNightQML/Deck-week6 branch from f99a567 to 5855cca Compare July 5, 2026 19:53

xARSENICx added 2 commits July 9, 2026 01:32

Merge branch 'main' into LateNightQML/Deck-week6

fb4f207

Merge remote-tracking branch 'origin/main' into LateNightQML/Deck-week6

6355228

xARSENICx force-pushed the LateNightQML/Deck-week6 branch from f4dd9e1 to 6355228 Compare July 18, 2026 09:46

JoergAtGithub requested changes Jul 19, 2026

View reviewed changes

fix(LateNightQML): address deck review feedback

fb35f76

acolombier previously requested changes Aug 1, 2026

View reviewed changes

github-actions Bot added the build label Aug 4, 2026

fix(LateNightQML): correct deck display and waveform markers

815cfb2

xARSENICx force-pushed the LateNightQML/Deck-week6 branch from e61a59d to 815cfb2 Compare August 8, 2026 15:38

xARSENICx requested review from JoergAtGithub and acolombier August 8, 2026 16:05

JoergAtGithub requested changes Aug 9, 2026

View reviewed changes

fix(LateNightQML): keep BPM editor open during input

238ab3f

xARSENICx force-pushed the LateNightQML/Deck-week6 branch from 506361a to 238ab3f Compare August 10, 2026 18:56

acolombier reviewed Aug 10, 2026

View reviewed changes

fix(LateNightQML): correct BPM editor layout and track fallback

5047d08

xARSENICx requested a review from JoergAtGithub August 13, 2026 12:17

	required property var track
	required property Mixxx.Track track

		@@ -26,41 +26,12 @@ Skin.EmbeddedText {
		property double remaining: durationControl.value * (1 - playPositionControl.value)

		function toTime(value) {

Uh oh!

Uh oh!

Conversation

xARSENICx commented Jul 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Testing the Experimental Skin

Previews

Classic

PaleMoon

Scope of Changes

Implemented in this PR:

Note:

Tracking

Uh oh!

ronso0 commented Jul 6, 2026

Uh oh!

xARSENICx commented Jul 6, 2026

Uh oh!

JoergAtGithub commented Jul 7, 2026

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

JoergAtGithub left a comment

Choose a reason for hiding this comment

Uh oh!

JoergAtGithub commented Aug 9, 2026

Uh oh!

JoergAtGithub commented Aug 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

xARSENICx commented Aug 13, 2026

xARSENICx commented Jul 5, 2026 •

edited

Loading

JoergAtGithub commented Aug 10, 2026 •

edited

Loading