updates for the "Korg Kaoss DJ" controller script

[raphaelquast]

New assignments:

browser Knob	browse library or playlist up & down (same as before)
shift + browser Knob	toggle focus between Playlist and File-Browser

tap	open folder
2 x tap	close folder
(left) shift + tap	tap bpm of left track
(right) shift + tap	tap bpm of right track

load A / B	load track to deck 1 / 2 (same as before)
shift + load A / B	open / close folder in file-browser

shift + touchpad X	control super knob of QuickEffectRack for deck 1
shift + touchpad Y	control super knob of QuickEffectRack for deck 2

changed assignments

• the loop-on button now works as follows:
  • if a loop is active, it deactivates the loop (same as before)
  • if no loop is active, a new beatloop is created at the current playback position
    (before a re-loop of the deactivated loop was triggered)

doc-updates:

mixxxdj/manual#430

[Swiftb0y]

Please install pre-commit and rerun it on the changed files. Thanks. Feel free to ask on zulip if you need help.

[raphaelquast]

@Swiftb0y i ran pre-commit and fixed all syntax errors..
however I'm unsure how to deal with the remaining no-unused-vars errors since they complain about the call-signatures of the callback functions

[Swiftb0y]

Thank you.

however I'm unsure how to deal with the remaining no-unused-vars errors since they complain about the call-signatures of the callback functions

Eslint is is configured to allow unused variables and parameters that start with an underscore (_). So just prefix those parameters with _ and eslint should not complain.

[Swiftb0y]

Also, keep in mind that there is some variety in those rules, so for instance in this case, its likely fine to just remove the parameter entirely.

16:5 error 'led' is assigned a value but never used no-unused-vars

[raphaelquast]

Eslint is is configured to allow unused variables and parameters that start with an underscore (_). So just prefix those parameters with _ and eslint should not complain.

OK I'll do that!

Also, keep in mind that there is some variety in those rules, so for instance in this case, its likely fine to just remove the parameter entirely.

16:5 error 'led' is assigned a value but never used no-unused-vars

I know... that variable is still from the original creator of the script so I don't want to remove it entirely...
I might just leave it there as a comment (it depicts the MIDI messages of the controller-buttons)

[uklotzde]

As a First-time contributor we have to ask you to sign the Mixxx Contributor Agreement before merging any contributions.

[raphaelquast]

As a First-time contributor we have to ask you to sign the Mixxx Contributor Agreement before merging any contributions.

OK, it's signed!

[github-actions]

This PR is marked as stale because it has been open 90 days with no activity.

[pi43r]

Just curious why this was not merged?
I think the assignment fixes some previous todos and is an overall improvement.

[raphaelquast]

hey @pi43r, there are some formatting issues with the updated documentation (mixxxdj/manual#430) and then it somewhat got lost because I had a lot of other things to do...

I'm not sure when I find some time to get the docs fixed, (even though it should only be some minor changes)

[github-actions]

This PR is marked as stale because it has been open 90 days with no activity.

[ronso0]

#12683 has been merged, closing this.