fix: preserve model version tags in OSS bulk export#244
Open
0guban0v wants to merge 1 commit into
Open
Conversation
search_model_versions omits tags/aliases on PostgreSQL backends. The non-UC path in list_model_versions was returning raw search results; now calls get_model_version per version, matching the existing UC path.
Author
|
@dbczumar could you complete review ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #240.
On PostgreSQL backends,
search_model_versions(used bySearchModelVersionsIterator) does not return tags or aliases on model versions. The non-UC path inlist_model_versionswas returning raw search results directly, so version tags were silently dropped during export.The UC path already handled this correctly by calling
get_model_versionper version. This PR applies the same approach to the non-UC path.