Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
@@ -1 +1,3 @@
__pycache__/
.venv/
*.egg-info/
3 changes: 2 additions & 1 deletion mlflow_export_import/common/model_utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,8 @@ def list_model_versions(client, model_name, get_latest_versions=False):
if get_latest_versions:
return client.get_latest_versions(model_name)
else:
return list(SearchModelVersionsIterator(client, filter=f"name='{model_name}'"))
versions = SearchModelVersionsIterator(client, filter=f"name='{model_name}'")
return [ client.get_model_version(vr.name, vr.version) for vr in versions ]


def search_model_versions(client, filter):
Expand Down
22 changes: 22 additions & 0 deletions tests/open_source/test_model_utils.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
from types import SimpleNamespace
from unittest import mock
from mlflow_export_import.common.model_utils import list_model_versions


def test_list_model_versions_fetches_full_version_for_oss():
"""
Regression test for issue #240.
search_model_versions omits tags on PostgreSQL backends. list_model_versions
must call get_model_version per version so tags are present in exported metadata.
"""
mock_client = mock.Mock()
full_version = SimpleNamespace(tags={"env": "prod"})
mock_client.get_model_version.return_value = full_version

with mock.patch(
"mlflow_export_import.common.model_utils.SearchModelVersionsIterator",
return_value=iter([SimpleNamespace(name="m", version="1")]),
):
result = list_model_versions(mock_client, "m")

assert result == [full_version]