chore(types,utils): delete dead ethermint-era helpers#320
Merged
Conversation
bb323c5 to
a8ccd8d
Compare
This was referenced Jul 8, 2026
These files were orphaned by the rpc/, in-tree x/evm, and x/erc20 removals: block.go (BlockGasLimit), gasmeter.go (infinite gas meter), int.go (SafeInt64/SafeUint64 — the latter re-orphaned when #309 deleted the rpc tests that used it), protocol.go, validation.go(+test), constant.go, openapiutil/, and utils/eth (DeriveChainID/RawSignatureValues, live copies of which ship in cosmos/evm's utils). Every exported symbol was verified to have zero references across the repo AND the three known external consumers (moca-storage-provider, moca-go-sdk, moca-challenger). Files those consumers do use — chain_id.go (ParseChainID is production code in the storage provider's signer), grn.go, s3util, resource, common — are untouched. Signed-off-by: puneetmahajan <59960662+puneet2019@users.noreply.github.com>
a8ccd8d to
a448eb6
Compare
Contributor
|
I think this should be treated as a breaking Go API change, not just dead-code deletion. The symbols removed here are exported from the published
The repo-wide zero-reference check is enough to prove they are dead internally, but it does not prove they are safe to delete for downstream Go consumers. Any external code importing these packages will fail to compile after upgrading to this PR. If the intent is a non-breaking cleanup, I think these need compat shims / deprecation first. If the intent is to break the module API, that should be called out explicitly as a breaking change rather than a routine chore cleanup. |
phenix3443
approved these changes
Jul 9, 2026
Contributor
Author
|
acknowledged, i am ok with breaking changes here |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of the shrink-to-upstream campaign (#309–#316). PR A of the dead-code series from the five-folder symbol-level sweep.
Summary
Deletes 10 dead files (−494 LOC) — 8 Go sources, 1 test, 1 template — orphaned by the
rpc/(#309), in-treex/evm, andx/erc20(#221) removals:types/block.goBlockGasLimit— rpc-era helpertypes/gasmeter.gotypes/int.goSafeInt64/SafeUint64(the latter added for #292's rpc tests — re-orphaned when #309 deleted them)types/protocol.goProtocolVersion— served the deleted rpctypes/validation.go+ testtypes/constant.goDefaultDenomtypes/openapiutil/utils/eth/eth.goDeriveChainID/RawSignatureValues— live copies ship in cosmos/evmutils/Safety
IsEmptyHash,IsZeroAddress,ErrorGasOverflow,ErrorNegativeGasConsumed,openapiutil.Handlerbeyond the originally listed 13) confirmed zero references across the repo — and, per the consumer sweep, across the three known external consumers (moca-storage-provider, moca-go-sdk, moca-challenger).types/chain_id.golooks test-only in-repo butParseChainIDis production code in the storage provider's signer — it,grn.go,s3util,resource,common, and the state-criticalaccount.*are untouched.go build ./...,go test ./types/... ./utils/..., full test-binary compile sweep (go test -run='^$' ./...), andgo vet ./e2e/...(outside CI's unit scope) — green locally and on an amd64 box.Next in the series: dead
client/testnet.go(PR B), two fork-neutral swaps (PR C), dead-symbol trims (PR D).🤖 Generated with Claude Code