feat(evm): migrate storage precompile to native runtime base#339
Merged
Conversation
Move the storage precompile onto x/evm/precompiles/base, same shape as the bank/storageprovider migrations: - embed base.Precompile; Run delegates to RunPrecompile; dispatch moves to Execute (existing handler map + base Dispatch/SetupABI for routing and read-only write protection via IsTransaction = !method.IsConstant()) - drop the hand-rolled cache-context / snapshot / commit template - gas calculators, event registration and AddLog/AddOtherLog kept as-is Runtime alignment only: EOA-only guards and per-handler readonly checks are kept; no balance handler wired. The storage baseline failure test is updated for native revert semantics: the "Group already exists" reason is decoded from the revert return data.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Part of subtask 3 (storage-series). Migrates the storage precompile (the largest, ~30 methods) onto
x/evm/precompiles/base, identical shape to bank #337 / storageprovider #338.Changes
Contractembedsbase.Precompile;Run→RunPrecompile; dispatch moves toExecute(existing handler map + baseDispatch/SetupABI,IsTransaction = !method.IsConstant()).AddLog/AddOtherLogunchanged.Behavior change (native revert semantics)
Failures revert with the reason ABI-encoded in the return data. The storage baseline
TestCreateGroup_FailureDoesNotMutateState(merged in #335) is updated to decodeGroup already existsviaabi.UnpackRevert(res.Ret); state-invariant / EOA-only / success assertions unchanged.Tests
go test ./x/evm/precompiles/storage -count=1→ ok.precompile-integration.