[bugfix] initialize step3 image inputs for text-only requests#8421
[bugfix] initialize step3 image inputs for text-only requests#8421mshicom wants to merge 1 commit intomodelscope:mainfrom
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a critical bug in the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request initializes image_inputs as an empty dictionary in the _encode function within swift/template/templates/stepfun.py. This change ensures that image_inputs is always defined, preventing a NameError when inputs.images is empty and encoded.update(image_inputs) is called. I have no feedback to provide.
| input_ids = encoded['input_ids'] | ||
| labels = encoded['labels'] | ||
| loss_scale = encoded.get('loss_scale', None) | ||
| image_inputs = {} |
There was a problem hiding this comment.
Summary
image_inputsinStep3VLTemplate._encode()before the image branch runsVerification