Skip to content

[bugfix] initialize step3 image inputs for text-only requests#8421

Open
mshicom wants to merge 1 commit intomodelscope:mainfrom
mshicom:codex/step3-template-image-inputs
Open

[bugfix] initialize step3 image inputs for text-only requests#8421
mshicom wants to merge 1 commit intomodelscope:mainfrom
mshicom:codex/step3-template-image-inputs

Conversation

@mshicom
Copy link

@mshicom mshicom commented Mar 24, 2026

Summary

  • initialize image_inputs in Step3VLTemplate._encode() before the image branch runs
  • avoid text-only Step3 requests failing when the template later updates the encoded payload

Verification

  • reproduced the text-only Step3 template failure locally before the change
  • verified text-only Step3 requests proceed through the template path after the fix

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a critical bug in the Step3VLTemplate that caused text-only requests to fail. The fix ensures robust handling of requests without images by explicitly initializing a variable that was previously only set when images were present. This change improves the stability and reliability of the template for diverse input types.

Highlights

  • Bug Fix: Resolved an issue where text-only requests would fail in the Step3VLTemplate._encode() method due to an uninitialized image_inputs variable.
  • Initialization: Ensured that the image_inputs dictionary is always initialized to an empty dictionary before any image-specific processing, preventing errors when no images are provided.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request initializes image_inputs as an empty dictionary in the _encode function within swift/template/templates/stepfun.py. This change ensures that image_inputs is always defined, preventing a NameError when inputs.images is empty and encoded.update(image_inputs) is called. I have no feedback to provide.

input_ids = encoded['input_ids']
labels = encoded['labels']
loss_scale = encoded.get('loss_scale', None)
image_inputs = {}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

This initialization of image_inputs is critical. Without it, image_inputs would be undefined if inputs.images is empty, leading to a NameError when encoded.update(image_inputs) is called later in the function. This change correctly addresses the bug for text-only requests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant