Skip to content

[bugfix] initialize step3 image inputs for text-only requests #8421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mshicom wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[bugfix] initialize step3 image inputs for text-only requests #8421

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions swift/template/templates/stepfun.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -316,6 +316,7 @@ def _encode(self, inputs: StdTemplateInputs) -> Dict[str, Any]:
input_ids = encoded['input_ids']
labels = encoded['labels']
loss_scale = encoded.get('loss_scale', None)
image_inputs = {}
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Mar 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

This initialization of image_inputs is critical. Without it, image_inputs would be undefined if inputs.images is empty, leading to a NameError when encoded.update(image_inputs) is called later in the function. This change correctly addresses the bug for text-only requests.


images = inputs.images
if images:
Expand Down