-
-
Notifications
You must be signed in to change notification settings - Fork 529
[Port to 3.x] Fix Various Issues with Resource/Element Validation and Field Display #15887
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Port of PR#15146 to 3.0 as well as many form panel code optimizations
...and one bug fix in resource panel
One important thing I wanted to note and get opinion on: As you all know the template element has a new preview feature. This is great, however it introduced an issue I didn't fully address in this PR: Now there are two file type fields in the editing form that need to refer to a Media Source, but sharing that source becomes a UI issue because of how the static file/source fields are now grouped together and hidden when not is use. The solution that comes to mind is to add a separate source field to associate with the preview file, an option that may be desirable by some anyway. |
@Mark-H @Ruslan-Aleev - Just bumping this, in particular to those who tested and approved these changes that were merged into 2.x (about this time last year). It'd be great to get this in before final release ;-) |
Why are there merges into this PR from 3.x? In the future, please rebase your work on top of latest 3.x and force push instead. |
@opengeek - Sorry, you're witnessing some of my lack of experience in the GIT world. So I'm guessing rebasing is the strategy for keeping an in-progress branch in sync with the branch it was based from; and I take it that keeps you from seeing all the un directly-related commits? Would it be of any help to rebase this branch now? |
No reason to rebase now. Merge commits are just messy. I'm of the philosophy that you should always rebase unless it is on a branch that is meant for public consumption or mass collaboration and is already published. At that point, merging is the only option. |
@opengeek @Mark-H @Ruslan-Aleev @Jako @Ibochkarev - OK all, as I'm having trouble getting this looked at as a whole (and I inconveniently made a couple 3.x merge commits), I'm going to break this up into a handful of separate PRs. Note that I'm submitting the first now (focused on the Resource panel), which should supersede the change @Ruslan-Aleev submitted in PR #16008. Again, to remind, this PR as a whole (minus a couple small updates) had already been merged into 2.8.0 back in Oct 2020, which is why I thought it would be relatively easy to get it merged into 3.x. |
What does it do?
Ports enhancements from PR #15146 to 3.x (including subsequent fixes by others) and incorporates UI updates introduced in PR #15773 made to the TV editing form into the rest of the element editing forms. Other changes include:
Why is it needed?
Makes needed UI and consistency improvements to the resource and element editing panels.
How to test
grunt build
from within the_build/templates/default
folder and clear your browser cache.Related issue(s)/PR(s)
Partly addresses #15854.