Skip to content

Fixed 'undefined' error if TV is located under content #16008

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 31, 2022
Merged

Fixed 'undefined' error if TV is located under content #16008

merged 1 commit into from
Jan 31, 2022

Conversation

Ruslan-Aleev
Copy link
Collaborator

What does it do?

Fixed 'undefined' error if TV is located under content, and not in the tab.
When saving the resource, an error occurred in the console and the validation message did not appear.

How to test

  1. Create a required TV.
  2. Position the TV below the content (setting tvs_below_content).
  3. Without setting a value in TV, save the resource and watch the console.

Related issue(s)/PR(s)

NA

@Ruslan-Aleev Ruslan-Aleev added pr/review-needed Pull request requires review and testing. type-frontend Issues related to UI/UX issues, mostly about styles and frontend implementations on JavaScript. labels Jan 26, 2022
@Ruslan-Aleev Ruslan-Aleev added this to the v3.0.0-rc2 milestone Jan 26, 2022
@Ibochkarev
Copy link
Collaborator

@cla-bot check

@cla-bot cla-bot bot added the cla-signed CLA confirmed for contributors to this PR. label Jan 29, 2022
@cla-bot
Copy link

cla-bot bot commented Jan 29, 2022

The cla-bot has been summoned, and re-checked this pull request!

@JoshuaLuckers JoshuaLuckers added pr/ready-for-merging Pull request reviewed and tested and ready for merging. and removed pr/review-needed Pull request requires review and testing. labels Jan 31, 2022
@opengeek opengeek merged commit 8f9c31b into modxcms:3.x Jan 31, 2022
@Ruslan-Aleev Ruslan-Aleev deleted the 3.x-validate-fix branch February 1, 2022 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed CLA confirmed for contributors to this PR. pr/ready-for-merging Pull request reviewed and tested and ready for merging. type-frontend Issues related to UI/UX issues, mostly about styles and frontend implementations on JavaScript.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants