Skip to content

Fix empty attributes with i.e. german umlaut in the transport package readme #16713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
opengeek merged 1 commit into from
Mar 20, 2025
Merged

Fix empty attributes with i.e. german umlaut in the transport package readme #16713

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion core/src/Revolution/Processors/Workspace/Packages/GetAttribute.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@
foreach ($attributesToGet as $attribute) {
$data = $this->transport->getAttribute($attribute);
$attributes[$attribute] = in_array($attribute,
['changelog', 'license', 'readme']) ? $parseDown->text(htmlentities($data)) : $data;
['changelog', 'license', 'readme']) ? $parseDown->text(htmlspecialchars($data)) : $data;

Check failure on line 81 in core/src/Revolution/Processors/Workspace/Packages/GetAttribute.php

View workflow job for this annotation

GitHub Actions / phpcs 

Multi-line function call not indented correctly; expected 12 spaces but found 16

Check failure on line 81 in core/src/Revolution/Processors/Workspace/Packages/GetAttribute.php

View workflow job for this annotation

GitHub Actions / phpcs 

Closing parenthesis of a multi-line function call must be on a line by itself

Check warning on line 81 in core/src/Revolution/Processors/Workspace/Packages/GetAttribute.php

View check run for this annotation

Codecov / codecov/patch

core/src/Revolution/Processors/Workspace/Packages/GetAttribute.php#L81 

Added line #L81 was not covered by tests

/* if setup options, include setup file */
if ($attribute === 'setup-options') {
Expand Down
Loading