Skip to content

Fix empty attributes with i.e. german umlaut in the transport package readme #16713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 20, 2025

Conversation

Jako
Copy link
Collaborator

@Jako Jako commented Feb 25, 2025

What does it do?

Change htmlentities to htmlspecialchars

Why is it needed?

In one of my packages I have used a ß in the readme for the transport package. When this transport package is installed, the result the of Workspace/Packages/GetAttribute processor is empty for some reason inside of the Parsedown class in combination with the processor response and the package can't be installed anymore.

How to test

Add a ß in the readme of a transport package.

Related issue(s)/PR(s)

None known

@Jako Jako requested review from opengeek and Mark-H as code owners February 25, 2025 10:15
Copy link

codecov bot commented Feb 25, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 21.52%. Comparing base (b1a02c3) to head (bc20c28).
Report is 33 commits behind head on 3.x.

Files with missing lines Patch % Lines
...ion/Processors/Workspace/Packages/GetAttribute.php 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                3.x   #16713      +/-   ##
============================================
- Coverage     21.53%   21.52%   -0.02%     
+ Complexity    10734    10720      -14     
============================================
  Files           565      565              
  Lines         32540    32533       -7     
============================================
- Hits           7007     7002       -5     
+ Misses        25533    25531       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@smg6511

This comment was marked as resolved.

@opengeek opengeek merged commit 03923e6 into modxcms:3.x Mar 20, 2025
8 of 9 checks passed
@Jako Jako deleted the patch-1 branch March 20, 2025 20:45
@opengeek opengeek added this to the v3.1.2 milestone Mar 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants