Draft
Conversation
Member
Author
|
@batmat: I have no idea how to answer your question. That said, I claim that my patch is correct, because even if it doesn't happen today due to some hand waving the code is still incredibly unhelpful and should be fixed. It's also buggy in that in theory it could complain about the major version when the problem is only the minor version. |
Vlatombe
added a commit
to Vlatombe/extra-enforcer-rules
that referenced
this pull request
Mar 20, 2019
src/main/java/org/apache/maven/plugins/enforcer/EnforceBytecodeVersion.java
Outdated
Show resolved
Hide resolved
Member
|
@jsoref, first of all, thanks for creating a PR.
|
When an error occurs, this information is provided by handleArtifacts. For warnings, the only information is the information provided by the getLog().warn() call itself. Without this change, the following output is common: [INFO] --- maven-enforcer-plugin:3.0.0-M2:enforce (display-info) @ acceptance-test-harness --- [WARNING] Invalid bytecodeVersion for module-info.class: expected 52, but was 53 [WARNING] Invalid bytecodeVersion for module-info.class: expected 52, but was 53 [WARNING] Invalid bytecodeVersion for module-info.class: expected 52, but was 53 [WARNING] Invalid bytecodeVersion for module-info.class: expected 52, but was 53 [WARNING] Invalid bytecodeVersion for module-info.class: expected 52, but was 53 [WARNING] Invalid bytecodeVersion for module-info.class: expected 52, but was 53 [WARNING] Invalid bytecodeVersion for module-info.class: expected 52, but was 53
992253b to
5e34af0
Compare
…eVersion.java Co-authored-by: Mirko Friedenhagen <mfriedenhagen@gmx.de>
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When an error occurs, this information is provided by
handleArtifacts.For warnings, the only information is the information provided by the
getLog().warn()call itself.Without this change, the following output is common: