Skip to content

testing merging of obsolete examination by a neurologist#692

Merged
pnrobinson merged 3 commits into
masterfrom
merging_test
Jun 9, 2025
Merged

testing merging of obsolete examination by a neurologist#692
pnrobinson merged 3 commits into
masterfrom
merging_test

Conversation

@pnrobinson

Copy link
Copy Markdown
Member

@matentzn I have merged one term (obsolete examination by a neurologist) the same was as in HPO. Could you please sanity check this? If it is OK, I will do the rest and we could make a new release. Thanks!

@matentzn matentzn left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The hasAlternativeProperty is not correctly formatted, but the actual obsoletion looks otherwise ok.

Unfortunately a lot of changes krept into this PR that are in conflict with the main branch.

If you want, I can recreate the obsoletion / replacement for you correctly so you have the correct property in place for the future.

Comment thread src/ontology/maxo-edit.owl Outdated
@pnrobinson

Copy link
Copy Markdown
Member Author

@matentzn Not entirely sure about what to do with this -- if there is an obvious way to fix this please do!
I also would like to add "database_cross_reference" for PMIDs as with hpo -- if there is a proper way to do this please add it!

@matentzn matentzn left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pnrobinson there you go!

@pnrobinson pnrobinson merged commit b37360c into master Jun 9, 2025
1 check passed
@pnrobinson pnrobinson deleted the merging_test branch June 9, 2025 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants