Add support for custom ROBOT plugins in Makefiles #9839
Conversation
Introduced new Makefile rules to manage ROBOT plugins, including installation of custom and supplementary plugins. Added targets for simple merge operations and an obsolete replacement test using the odk plugin in mondo.Makefile. These changes improve plugin management and extend ontology processing capabilities.
|
@ptgolden is PR is a precursor for adding the updated sssom-java into the Mondo pipeline. This is only necessary while we do not have an ODK minor release, but it is necessary so we can move forward. Unfortunately Mondo, the most important ontology in my portfolio, is xactly the only ontology that has not been migrated to a proper ODK setup where all of this is automated. |
|
|
||
| $(ROBOT_PLUGINS_DIRECTORY)/odk.jar: | ||
| #cp /Users/matentzn/ws/odk-robot-plugin/target/odk.jar $@ | ||
| echo uncommentme |
There was a problem hiding this comment.
Where is the odk.jar coming from?
|
|
||
| obsolete-replace-test: #cp-odk-plug | ||
| $(ROBOT) odk:obsolete-replace --input $(SRC) --obsolete MONDO:0032564 --replacement MONDO:0032565 -o $(SRC) | ||
|
|
There was a problem hiding this comment.
Consider having obsolete-replace-test depend on extra_robot_plugins.
| .PHONY: all_robot_plugins | ||
| all_robot_plugins: $(foreach plugin,$(notdir $(wildcard /tools/robot-plugins/*.jar)),$(ROBOT_PLUGINS_DIRECTORY)/$(plugin)) \ | ||
| $(foreach plugin,$(notdir $(wildcard ../../plugins/*.jar)),$(ROBOT_PLUGINS_DIRECTORY)/$(plugin)) \ | ||
| custom_robot_plugins extra_robot_plugins \ |
| ln ../../plugins/$*.jar $@ ; \ | ||
| elif [ -f /tools/robot-plugins/$*.jar ]; then \ | ||
| cp /tools/robot-plugins/$*.jar $@ ; \ | ||
| fi |
There was a problem hiding this comment.
The rule silently succeeds even if the source file doesn't exist. Add an else clause to fail explicitly when the source file isn't found.
twhetzel
left a comment
twhetzel
left a comment
There was a problem hiding this comment.
The overall idea makes sense, but there are spots that would benefit from updates.
Introduced new Makefile rules to manage ROBOT plugins, including installation of custom and supplementary plugins. Added targets for simple merge operations and an obsolete replacement test using the odk plugin in mondo.Makefile. These changes improve plugin management and extend ontology processing capabilities.