feat: add m2tsMuxRate field and null-packet CBR warning - #10
Merged
Conversation
* Add warning in §5.5 that null packet removal changes inter-packet byte spacing, breaking CBR mux-clock recovery for downstream receivers * Add optional advisory catalog field m2tsMuxRate (bits/s) so subscribers can restore the original mux rate when null packets have been removed * Add m2tsMuxRate to catalog table and field definitions Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses point 2 of #7 — null packet removal breaks CBR byte-clock and mux-clock recovery.
Point 2 notes that §5.5 permits null packet removal at publisher discretion, but removing null packets changes the byte distance between successive PCRs. Constant-bit-rate receivers use that spacing to reconstruct the mux clock; without it, a downstream device must re-derive a rate it was never told. The issue suggested either recommending that nulls be retained for CBR reconstruction, or defining an advisory catalog field for the source mux rate.
This PR implements the catalog field option.
Changes
§5.5 Multi-Program Source Handling — adds a paragraph warning that removing null packets changes the inter-packet byte spacing that constant-bit-rate receivers use to recover the mux clock, and that publishers removing null packets SHOULD declare
m2tsMuxRate.Catalog table — new
m2tsMuxRateentry.New field
m2tsMuxRate— optional advisory Number (bits/s). A subscriber reconstructing a constant-bit-rate output stream MAY use this value to restore the original mux rate when null packets have been removed.