feat: add m2tsSiPids field and SI table retention guidance - #11
Merged
Conversation
* Add paragraph in §5.5 noting that the PMT-centric retain filter silently drops DVB/ATSC SI tables (SDT/EIT/TDT/TOT/NIT/PSIP); publishers targeting broadcast or IRD deployments SHOULD retain the required SI tables and declare retained PIDs via m2tsSiPids * Add optional advisory catalog field m2tsSiPids (Array) listing packet identifiers of SI tables retained beyond the PMT filter * Add m2tsSiPids to catalog table Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Owner
|
@gwendalsimon can you check the resolved conflict? |
Collaborator
Author
Yes, I think it is fine. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses point 1 of #7 — the §5.5 retain filter silently drops DVB and ATSC service information tables.
Point 1 observes that the PMT-centric retain list in §5.5 does not include SI tables carried on fixed well-known PIDs: SDT/BAT (0x0011), EIT (0x0012), TDT/TOT (0x0014), and NIT (0x0010), or their ATSC PSIP equivalents. A publisher implementing §5.5 without additional care produces a track with no service identity, no EPG, and no broadcast time — a disqualifier for IRD-based deployments. The issue suggested either a normative note or a catalog hint for retained SI PIDs.
This PR implements both.
Changes
§5.5 Multi-Program Source Handling — adds a paragraph noting that the PMT-centric filter silently drops DVB and ATSC SI tables, listing the affected PIDs, and stating that publishers targeting broadcast or IRD deployments SHOULD retain the required SI tables and SHOULD declare the retained PIDs using
m2tsSiPids.Catalog table — new
m2tsSiPidsentry.New field
m2tsSiPids— optional advisory Array of packet identifiers retained in the filtered track beyond those listed in the Program Map Table. Subscribers MAY use this list to verify which service information tables are present without inspecting the packet stream.