⭐️ add actionlint for GitHub Actions linting#1373
Merged
chris-rock merged 4 commits intomainfrom Feb 6, 2026
Merged
Conversation
Contributor
- Add actionlint job to lint.yaml CI workflow - Add `make lint/actions` target for local linting - Fix invalid `secrets` section in cloud-tests.yaml workflow_dispatch - Fix bogus step references in slack notification jobs - Add missing secret declarations in integration-tests.yaml Closes #673 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
chris-rock
force-pushed
the
add-actionlint
branch
from
14022af to
adfc2aa
Compare
- Pin actionlint version to v1.7.10 instead of @latest - Mark MONDOO_TEST_ORG_TOKEN as required (tests depend on it) - Enable shellcheck in actionlint for full linting coverage Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
chris-rock
commented
Feb 6, 2026
| steps: | ||
| - name: Send Slack notification on failure | ||
| uses: slackapi/slack-github-action@91efab103c0de0a537f72a35f6b8cda0ee76bf0a # v2.1.1 | ||
| if: ${{ always() && steps.build-providers.outcome != 'success' }} |
Member
Author
There was a problem hiding this comment.
we have the condition on the job level, so we do not need this here anymore
| steps: | ||
| - name: Send Slack notification on failure | ||
| uses: slackapi/slack-github-action@91efab103c0de0a537f72a35f6b8cda0ee76bf0a # v2.1.1 | ||
| if: ${{ always() && steps.build-providers.outcome != 'success' }} |
Member
Author
There was a problem hiding this comment.
we have the if condition on the job level, so we do not need this here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
make lint/actionstarget for local linting before pushingsecretssection underworkflow_dispatchin cloud-tests.yamlsteps.build-providersin slack notification jobsworkflow_callCloses #673
Test plan
make lint/actionsruns successfully locally🤖 Generated with Claude Code