-
Notifications
You must be signed in to change notification settings - Fork 17
⭐️ add actionlint for GitHub Actions linting #1373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
adfc2aa
⭐️ add actionlint for GitHub Actions linting
chris-rock 67c9112
🔧 fix actionlint configuration issues
chris-rock 0bbeca9
🔧 keep shellcheck disabled until existing warnings are fixed
chris-rock 9b1d228
Add CLAUDE.md with linting instructions
chris-rock File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -10,6 +10,10 @@ on: | |
| required: true | ||
| MONDOO_CLIENT_EDGE: | ||
| required: true | ||
| MONDOO_TEST_ORG_TOKEN: | ||
| required: true | ||
| SLACK_BOT_TOKEN: | ||
| required: false | ||
|
|
||
| env: | ||
| CNSPEC_IMAGE_TAG: ${{ github.event.inputs.cnspecImageTag }} | ||
|
|
@@ -179,7 +183,6 @@ jobs: | |
| steps: | ||
| - name: Send Slack notification on failure | ||
| uses: slackapi/slack-github-action@91efab103c0de0a537f72a35f6b8cda0ee76bf0a # v2.1.1 | ||
| if: ${{ always() && steps.build-providers.outcome != 'success' }} | ||
|
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. we have the if condition on the job level, so we do not need this here. |
||
| with: | ||
| method: chat.postMessage | ||
| token: ${{ secrets.SLACK_BOT_TOKEN }} | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| # Claude Code Instructions | ||
|
|
||
| ## Before Pushing Changes | ||
|
|
||
| Always run the following linters before pushing any changes: | ||
|
|
||
| ```bash | ||
| make lint # Go linting | ||
| make lint/actions # GitHub Actions linting | ||
| ``` | ||
|
|
||
| ## Project Overview | ||
|
|
||
| This is the Mondoo Operator - a Kubernetes operator for Mondoo security scanning. | ||
|
|
||
| ## Common Commands | ||
|
|
||
| - `make test` - Run unit tests | ||
| - `make lint` - Run Go linter | ||
| - `make lint/actions` - Lint GitHub Actions workflows | ||
| - `make build` - Build the operator | ||
| - `make docker-build` - Build container image |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we have the condition on the job level, so we do not need this here anymore