Merged
Conversation
Contributor
czunker
force-pushed
the
czunker/rm_docker_pin
branch
from
788563c to
9c60043
Compare
The new release of https://github.com/google/go-containerregistry/releases/tag/v0.20.4 allows us to remove the pin Signed-off-by: Christian Zunker <christian@mondoo.com>
moby/moby#47936 Signed-off-by: Christian Zunker <christian@mondoo.com>
=== Errors Error: providers-sdk/v1/lr/docs/docs.go:56:21: non-constant format string in call to fmt.Sprintf Error: cli/components/list.go:51:48: non-constant format string in call to fmt.Fprintf Error: apps/cnquery/cmd/bundle.go:103:28: non-constant format string in call to fmt.Fprintf Error: apps/cnquery/cmd/bundle.go:141:28: non-constant format string in call to fmt.Fprintf Error: providers-sdk/v1/inventory/asset.go:44:22: non-constant format string in call to fmt.Sprintf Signed-off-by: Christian Zunker <christian@mondoo.com>
Signed-off-by: Christian Zunker <christian@mondoo.com>
czunker
force-pushed
the
czunker/rm_docker_pin
branch
from
9c60043 to
dedf98e
Compare
glower
reviewed
May 21, 2025
| out := cmd.GetStdout() | ||
| if out.Error != nil { | ||
| return nil, fmt.Errorf("could not run auditpol: " + out.Error.Error()) | ||
| return nil, fmt.Errorf("could not run auditpol: %s", out.Error.Error()) |
Contributor
There was a problem hiding this comment.
nit: fmt.Errorf("could not run auditpol: %w", out.Error)
Contributor
Author
There was a problem hiding this comment.
Nice, thanks. I changed it.
glower
approved these changes
May 21, 2025
glower
reviewed
May 21, 2025
| out := cmd.GetStdout() | ||
| if out.Error != nil { | ||
| return nil, fmt.Errorf("could not run auditpol: " + out.Error.Error()) | ||
| return nil, fmt.Errorf("could not run auditpol: %s", out.Error.Error()) |
Contributor
Author
There was a problem hiding this comment.
Nice, thanks. I changed it.
Signed-off-by: Christian Zunker <christian@mondoo.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The new release of https://github.com/google/go-containerregistry/releases/tag/v0.20.4 allows us to remove the pin
Details for the docker type changes: moby/moby#47936