Conversation
The previous version ran all tests in the services package on Windows, which included Linux/macOS tests that fail due to path separators and symlinks. Now dynamically discovers packages containing _windows_test.go files and only runs those. See: #6474 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Add _windows_test.go files to exercise native Windows code paths (registry API, WMI, IP Helper API, fsutil) that were previously untested. These tests complement the Windows CI workflow from PR #6687. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
/review |
- Use relative paths for package discovery (DirectoryName returns absolute) - Filter empty strings from package split to avoid ghost arguments - Propagate go test exit code through Tee-Object - Add -count=1 to disable test caching in CI Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
/review |
1 similar comment
|
/review |
|
/review |
|
Unable to complete the code review. Reason: An internal error occurred during the review. Error detailsYou can try |
mondoo-code-review
bot
dismissed
their stale review
Dismissed: review could not be completed
Pass test packages via environment variable instead of direct interpolation to prevent potential script injection. Remove push trigger to match the PR-only intent of the workflow filename. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
/review |
![mondoo-code-review[bot]](https://avatars.githubusercontent.com/in/2834902?s=60&v=4){kind=small}
| $rel = ($_.DirectoryName -replace '\\','/').Replace($repoRoot + '/', '') | ||
| "./$rel/..." | ||
| } | | ||
| Sort-Object -Unique |
There was a problem hiding this comment.
🔵 suggestion — Appending /... makes each entry match the package and all sub-packages. If _windows_test.go files exist in both providers/os/a/ and providers/os/a/b/, Sort-Object -Unique won't deduplicate them (different strings), so tests in b will be run twice — once via ./providers/os/a/... and once via ./providers/os/a/b/.... go test tolerates this (no incorrect results), but you could avoid the redundant work by dropping the /... suffix (i.e. use ./$rel) since you're already enumerating every directory that contains test files.
2 participants
Summary
//go:build windows) onwindows-latestrunnersproviders/os/**in pushes and pull requestsTest plan
//go:build windowstest files🤖 Generated with Claude Code