cleanup: small grammatical improvements [beta] - #2663
Merged
Conversation
|
selsta
approved these changes
May 17, 2026
redsh4de
approved these changes
May 17, 2026
plowsof
reviewed
May 17, 2026
| "acceptPayment": { | ||
| "title": "Accept Your First Payment!", | ||
| "description": "A customer scans your QR code or copies your address and sends Monero from their wallet. You'll see the payment appear in your wallet or dashboard within seconds.", | ||
| "description": "A customer scans your QR code or copies your address, and sends Monero from their wallet. You'll see the payment appear in your wallet or dashboard within seconds.", |
Collaborator
There was a problem hiding this comment.
"," here looks odd , should probably be s/and/then
plowsof
reviewed
May 17, 2026
| "doesMoneroUseEncryption": { | ||
| "title": "Does Monero use encryption?", | ||
| "content": "Yes. Monero uses strong public key encryption and zero knowledge proofs so that transaction data is never published in plain form.\n\nOn chain you only see encrypted commitments and proofs that the rules are followed, instead of a readable payment history." | ||
| "content": "Yes. Monero uses strong public key encryption and zero-knowledge proofs so that transaction data is never published in plain form.\n\nOn chain you only see encrypted commitments and proofs that the rules are followed, instead of a readable payment history." |
Contributor
There was a problem hiding this comment.
goes through safeMarkdown so gets converted into linebreaks at build time
plowsof
reviewed
May 17, 2026
| "acceptPayment": { | ||
| "title": "Accept Your First Payment!", | ||
| "description": "A customer scans your QR code or copies your address and sends Monero from their wallet. You'll see the payment appear in your wallet or dashboard within seconds.", | ||
| "description": "A customer scans your QR code or copies your address, and sends Monero from their wallet. You'll see the payment appear in your wallet or dashboard within seconds.", |
Collaborator
There was a problem hiding this comment.
Suggested change
| "description": "A customer scans your QR code or copies your address, and sends Monero from their wallet. You'll see the payment appear in your wallet or dashboard within seconds.", | |
| "description": "A customer scans your QR code or copies your address, then sends Monero from their wallet. You'll see the payment appear in your wallet or dashboard within seconds.", |
nahuhh
changed the title
selsta
approved these changes
May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.