Skip to content

Conversation

@mimiflynn
Copy link
Member

Just add /site/content/!

@mimiflynn mimiflynn self-assigned this May 20, 2025
@mimiflynn mimiflynn requested a review from a team as a code owner May 20, 2025 15:22
@mimiflynn mimiflynn added the documentation Improvements or additions to documentation label May 20, 2025
@codecov
Copy link

codecov bot commented May 20, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.88%. Comparing base (4db9a26) to head (7338c05).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #168   +/-   ##
=======================================
  Coverage   90.88%   90.88%           
=======================================
  Files          40       40           
  Lines        4970     4970           
  Branches      847      847           
=======================================
  Hits         4517     4517           
  Misses        439      439           
  Partials       14       14           
Flag Coverage Δ
unittests 90.88% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@Roaders Roaders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume that this is a copy paste from Compose UI but with no actual FDC3 content added? What's the plan for updating the content?


### Context

ComposeUI has several very explicit goals that make the practice and
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is talking about Compose UI. We probably want to update that before merging?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, you would want to replace the sample ADR with the ones for this project.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we have none should this be deleted?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It could be if you don't intend to use ADRs. I am happy to change the project name to FDC3-web.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I realize you might be hesitant about the ADR but this documentation won't publish until we point GH pages to it. If you want to add documentation to this PR that is fine, but I intended for this to be a template that your team would fill out with documentation after initial merge. Once its ready, it would be published.

@mimiflynn
Copy link
Member Author

All of the content is sample content for your team to replace with real content.

@mimiflynn mimiflynn requested a review from Roaders November 18, 2025 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants