-
Notifications
You must be signed in to change notification settings - Fork 6
Docs site #168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #168 +/- ##
=======================================
Coverage 90.88% 90.88%
=======================================
Files 40 40
Lines 4970 4970
Branches 847 847
=======================================
Hits 4517 4517
Misses 439 439
Partials 14 14
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Roaders
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume that this is a copy paste from Compose UI but with no actual FDC3 content added? What's the plan for updating the content?
|
|
||
| ### Context | ||
|
|
||
| ComposeUI has several very explicit goals that make the practice and |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is talking about Compose UI. We probably want to update that before merging?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, you would want to replace the sample ADR with the ones for this project.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we have none should this be deleted?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It could be if you don't intend to use ADRs. I am happy to change the project name to FDC3-web.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I realize you might be hesitant about the ADR but this documentation won't publish until we point GH pages to it. If you want to add documentation to this PR that is fine, but I intended for this to be a template that your team would fill out with documentation after initial merge. Once its ready, it would be published.
|
All of the content is sample content for your team to replace with real content. |
Just add
/site/content/!