-
Notifications
You must be signed in to change notification settings - Fork 6
Docs site #168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mimiflynn
wants to merge
9
commits into
main
Choose a base branch
from
docs-site
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Docs site #168
Changes from 7 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
dd06963
docs site template
mimiflynn 7124822
docs site doc update
mimiflynn 04ff815
Merge branch 'main' of https://github.com/morganstanley/fdc3-web into…
mimiflynn db451ab
update theme version
mimiflynn 415b475
Merge branch 'main' of https://github.com/morganstanley/fdc3-web into…
mimiflynn 7a9bec2
Update ADR template
mimiflynn 98a76c0
Add docs site to ignore in eslint config
mimiflynn 3ab4994
Merge branch 'main' into docs-site
mimiflynn 7338c05
Merge branch 'main' into docs-site
mimiflynn File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,38 @@ | ||
| name: GH Page Deploy | ||
|
|
||
| on: | ||
| push: | ||
| branches: | ||
| - main | ||
|
|
||
| defaults: | ||
| run: | ||
| working-directory: ./site | ||
|
|
||
| jobs: | ||
| build: | ||
| runs-on: ubuntu-latest | ||
|
|
||
| permissions: | ||
| contents: write | ||
| packages: read | ||
|
|
||
| steps: | ||
| - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2 | ||
| - name: Use Node.js | ||
| uses: actions/setup-node@1d0ff469b7ec7b3cb9d8673fde0c81c44821de2a # v4.2.0 | ||
| with: | ||
| node-version: '22.x' | ||
| registry-url: 'https://npm.pkg.github.com' | ||
| scope: '@morganstanley' | ||
| - run: npm ci | ||
| env: | ||
| NODE_AUTH_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
| - run: npm run build | ||
| - name: Deploy | ||
| uses: crazy-max/ghaction-github-pages@fbf0a4fa4e00f45accd6cf3232368436ec06ed59 # v4.1.0 | ||
| with: | ||
| target_branch: gh-pages | ||
| build_dir: docs | ||
| env: | ||
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,31 @@ | ||
| name: GH Page PR Build | ||
|
|
||
| on: | ||
| pull_request: | ||
| branches: | ||
| - main | ||
|
|
||
| defaults: | ||
| run: | ||
| working-directory: ./site | ||
|
|
||
| jobs: | ||
| build: | ||
| runs-on: ubuntu-latest | ||
|
|
||
| permissions: | ||
| contents: read | ||
| packages: read | ||
|
|
||
| steps: | ||
| - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2 | ||
| - name: Use Node.js | ||
| uses: actions/setup-node@1d0ff469b7ec7b3cb9d8673fde0c81c44821de2a # v4.2.0 | ||
| with: | ||
| node-version: '22.x' | ||
| registry-url: 'https://npm.pkg.github.com' | ||
| scope: '@morganstanley' | ||
| - run: npm ci | ||
| env: | ||
| NODE_AUTH_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
| - run: npm run build |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,69 @@ | ||
| # Logs | ||
| logs | ||
| *.log | ||
| npm-debug.log* | ||
| yarn-debug.log* | ||
| yarn-error.log* | ||
|
|
||
| # Runtime data | ||
| pids | ||
| *.pid | ||
| *.seed | ||
| *.pid.lock | ||
|
|
||
| # Directory for instrumented libs generated by jscoverage/JSCover | ||
| lib-cov | ||
|
|
||
| # Coverage directory used by tools like istanbul | ||
| coverage | ||
|
|
||
| # nyc test coverage | ||
| .nyc_output | ||
|
|
||
| # Grunt intermediate storage (http://gruntjs.com/creating-plugins#storing-task-files) | ||
| .grunt | ||
|
|
||
| # Bower dependency directory (https://bower.io/) | ||
| bower_components | ||
|
|
||
| # node-waf configuration | ||
| .lock-wscript | ||
|
|
||
| # Compiled binary addons (http://nodejs.org/api/addons.html) | ||
| build/Release | ||
|
|
||
| # Dependency directories | ||
| node_modules/ | ||
| jspm_packages/ | ||
|
|
||
| # Typescript v1 declaration files | ||
| typings/ | ||
|
|
||
| # Optional npm cache directory | ||
| .npm | ||
|
|
||
| # Optional eslint cache | ||
| .eslintcache | ||
|
|
||
| # Optional REPL history | ||
| .node_repl_history | ||
|
|
||
| # Output of 'npm pack' | ||
| *.tgz | ||
|
|
||
| # dotenv environment variable files | ||
| .env* | ||
|
|
||
| # gatsby files | ||
| .cache/ | ||
| public | ||
|
|
||
| # Mac files | ||
| .DS_Store | ||
|
|
||
| # Yarn | ||
| yarn-error.log | ||
| .pnp/ | ||
| .pnp.js | ||
| # Yarn Integrity file | ||
| .yarn-integrity |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| .cache | ||
| package.json | ||
| package-lock.json | ||
| public |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| { | ||
| "endOfLine": "lf", | ||
| "semi": true, | ||
| "singleQuote": true, | ||
| "tabWidth": 2, | ||
| "trailingComma": "es5" | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,69 @@ | ||
| # Morgan Stanley GitHub Pages Documentation Gatsby Theme | ||
|
|
||
| ## Creating a documentation site for your project | ||
|
|
||
| ### Prerequisites | ||
|
|
||
| Ensure that the appropriate version of `node` and `npm` is available in your workspace. Please refer to the `engines` attribute of the `package.json` for the current expected version. | ||
|
|
||
| ### Personal Access Token for GitHub Packages | ||
|
|
||
| The theme that builds the branded documentation site is a private package. To build the site locally, you will need to generate a personal access token and add it to your `.npmrc`. | ||
|
|
||
| ``` | ||
| //npm.pkg.github.com/:_authToken=ghp_<token goes here> | ||
| @morganstanley:registry=https://npm.pkg.github.com/ | ||
| ``` | ||
|
|
||
| [Authenticating to GitHub Packages](https://docs.github.com/en/packages/working-with-a-github-packages-registry/working-with-the-npm-registry#authenticating-to-github-packages) | ||
|
|
||
| ### Template starter site | ||
|
|
||
| Copy and paste the `site/` directory of the `ms-gh-pages` project into the root of your project then update the `siteMetadata` key in the `gatsby-config.js` file to match your project's information. | ||
|
|
||
| ```json | ||
| siteMetadata: { | ||
| title: `Project GitHub Pages Template`, // your project's name | ||
| description: `Morgan Stanley Open Source Software`, // your project's description | ||
| siteUrl: `http://opensource.morganstanley.com`, // your project's url | ||
| } | ||
| ``` | ||
|
|
||
| ### Development Preview Server | ||
|
|
||
| Go to http://localhost:8000 for the development preview of the website. | ||
|
|
||
| ```shell | ||
| cd site | ||
| npm install | ||
| npm run start | ||
| ``` | ||
|
|
||
| ### Update the Content | ||
|
|
||
| Update the appropriate files located in the `site/content` directory with documentation for your project. For instance, to change the homepage text, update the `site/content/index.mdx`. Please be sure to _replace the content of each file in at least `/index.mdx` and `/documentation`_ to ensure a consistent experience across the Firm's Open Source projects. | ||
|
|
||
| ``` | ||
| / | ||
| --/site | ||
| ----/content | ||
| ------/architecture - directory linked in header navigation | ||
| --------index.mdx -> architecture landing page | ||
| ------/documentation - directory linked in header navigation | ||
| --------index.mdx -> documentation landing page | ||
| ------index.mdx -> Site Homepage | ||
| ``` | ||
|
|
||
| ### Dependabot | ||
|
|
||
| The Morgan Stanley GitHub page documentation theme is a package that can be updated via Dependabot. Because its a private package, Dependabot will need to be given permission through a token. Update your project's `.github/dependabot.yml` with: | ||
|
|
||
| ```yaml | ||
| registries: | ||
| npm-ghp: | ||
| type: npm-registry | ||
| url: 'https://npm.pkg.github.com' | ||
| token: ${{ secrets.GITHUB_TOKEN }} | ||
| ``` | ||
|
|
||
| Please refer to the [Dependabot Documentation](https://docs.github.com/en/code-security/dependabot/working-with-dependabot/configuring-access-to-private-registries-for-dependabot). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,73 @@ | ||
| --- | ||
| type: ADR | ||
| id: adr-001 | ||
| status: Accepted | ||
| scope: global | ||
| deciders: github group | ||
| date: 2021-06-01 | ||
| title: Use ADRs | ||
| --- | ||
|
|
||
| {/* Morgan Stanley makes this available to you under the Apache License, Version 2.0 (the "License"). You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0. See the NOTICE file distributed with this work for additional information regarding copyright ownership. Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. */} | ||
|
|
||
| ### Context | ||
|
|
||
| ComposeUI has several very explicit goals that make the practice and | ||
| discipline of architecture very important: | ||
|
|
||
| - We want to think deeply about all our architectural decisions, | ||
| exploring all alternatives and making a careful, considered, | ||
| well-researched choice. | ||
| - We want to be as transparent as possible in our decision-making | ||
| process. | ||
| - We don't want decisions to be made unilaterally in a | ||
| vacuum. Specifically, we want to give our steering group the | ||
| opportunity to review every major decision. | ||
| - Despite being a geographically and temporally distributed team, we | ||
| want our contributors to have a strong shared understanding of the | ||
| technical rationale behind decisions. | ||
| - We want to be able to revisit prior decisions to determine fairly if | ||
| they still make sense, and if the motivating circumstances or | ||
| conditions have changed. | ||
|
|
||
| ### Decision | ||
|
|
||
| We will document every architecture-level decision for ComposeUI and its | ||
| core modules with an | ||
| [Architecture Decision Record](http://thinkrelevance.com/blog/2011/11/15/documenting-architecture-decisions). These | ||
| are a well structured, relatively lightweight way to capture | ||
| architectural proposals. They can serve as an artifact for discussion, | ||
| and remain as an enduring record of the context and motivation of past | ||
| decisions. | ||
|
|
||
| The workflow will be: | ||
|
|
||
| 1. A developer creates an ADR document outlining an approach for a | ||
| particular question or problem. The ADR has an initial status of "proposed." | ||
| 2. The developers and steering group discuss the ADR. During this | ||
| period, the ADR should be updated to reflect additional context, | ||
| concerns raised, and proposed changes. | ||
| 3. Once consensus is reached, ADR can be transitioned to either an | ||
| "accepted" or "rejected" state. | ||
| 4. Only after an ADR is accepted should implementing code be committed | ||
| to the main branch of the relevant project/module. | ||
| 5. If a decision is revisited and a different conclusion is reached, a | ||
| new ADR should be created documenting the context and rationale for | ||
| the change. The new ADR should reference the old one, and once the | ||
| new one is accepted, the old one should (in its "status" section) | ||
| be updated to point to the new one. The old ADR should not be | ||
| removed or otherwise modified except for the annotation pointing to | ||
| the new ADR. | ||
|
|
||
| ### Consequences | ||
|
|
||
| 1. Developers must write an ADR and submit it for review before | ||
| selecting an approach to any architectural decision -- that is, any | ||
| decision that affects the way ComposeUI or a ComposeUI application is | ||
| put together at a high level. | ||
| 2. We will have a concrete artifact around which to focus discussion, | ||
| before finalizing decisions. | ||
| 3. If we follow the process, decisions will be made deliberately, as a group. | ||
| 4. The main branch of our repositories will reflect the high-level | ||
| consensus of the steering group. | ||
| 5. We will have a useful persistent record of why the system is the way it is. | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| --- | ||
| title: Architecture Decision Records | ||
| order: 0 | ||
| --- | ||
|
|
||
| <Hero title="Architecture Decision Records"> | ||
| Directory of Architecture Decision Records (ADRs) for Morgan Stanley Open | ||
| Source projects. | ||
| </Hero> | ||
| <Toc directory="architecture" /> |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is talking about Compose UI. We probably want to update that before merging?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, you would want to replace the sample ADR with the ones for this project.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we have none should this be deleted?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It could be if you don't intend to use ADRs. I am happy to change the project name to FDC3-web.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I realize you might be hesitant about the ADR but this documentation won't publish until we point GH pages to it. If you want to add documentation to this PR that is fine, but I intended for this to be a template that your team would fill out with documentation after initial merge. Once its ready, it would be published.