Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for GCLB cookie #62

Closed
wants to merge 1 commit into from
Closed

Conversation

jnahlers
Copy link

@jnahlers jnahlers commented Dec 8, 2022

@itstorque has written this commit to address the issues with the GCLB cookie (in this issue).

@Lightup1
Copy link

Not work in my case.

@Lightup1
Copy link

Seems need to reload olauth

@Lightup1
Copy link

It now works! just reload olauth!

@liamoconnor9
Copy link

liamoconnor9 commented Dec 14, 2022

Works after olauth reload for me

edit: thanks @moritzgloeckl and @itstorque for creating/maintaining this! not all heroes wear capes :)

@Usgupta
Copy link

Usgupta commented Jan 14, 2023

how do we use this new version? @itstorque @moritzgloeckl is it merged to master?

@dan-les
Copy link

dan-les commented Jan 30, 2023

Thanks, it works!

Copy link

@jacopoaltieri jacopoaltieri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change fixed the querying problem.

@negarnegma
Copy link

Thanks, it works!

This change fixed the querying problem.

@sergei-mironov
Copy link

sergei-mironov commented Jun 11, 2023

Sorry to say, this doesn't work for me, even after removing .olauth cookie file and repeating the login procedure. The error is

$ ols   -r  --store-path=/workspace/.olauth   --name "myproject"   --verbose
Project queried successfully.
✅  Querying project
⠋ Querying project detailsTraceback (most recent call last):
  File "/workspace/modules/overleaf-sync/olsync/olsync.py", line 348, in execute_action
    success = action()
  File "/workspace/modules/overleaf-sync/olsync/olsync.py", line 73, in <lambda>
    lambda: overleaf_client.get_project_infos(project["id"]),
  File "/workspace/modules/overleaf-sync/olsync/olclient.py", line 169, in get_project_infos
    self._cookie["GCLB"],
KeyError: 'GCLB'

💥  Querying project details
Error: Project details could not be queried.

Do I need to do anything special to "reload oauth", besides re-logging-in?

@sergei-mironov sergei-mironov mentioned this pull request Jun 11, 2023
@sergei-mironov
Copy link

Update: applying #66 did help me to make it work. So probably this PR should be deprecated in it's favor.

@jnahlers
Copy link
Author

As per above, let's close this PR and direct people to #66.

@jnahlers jnahlers closed this Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants