refactor(test): keep coverage at behavioral boundaries - #474
Merged
Conversation
morluto
marked this pull request as ready for review
August 11, 2026 10:21
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
Owner
Author
|
Codex Review: Didn't find any major issues. Another round soon, please! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Continue the test-debt sweep by assigning tests to the narrowest behavioral owner and removing coverage that only mirrored implementation details, private listener/timer state, type structure, or stronger tests elsewhere.
This change:
The sweep does not change tool contracts, provider authority, persistence semantics, or authorization behavior. Domain schema refactoring is intentionally excluded and tracked separately in #473.
Performance
On the same local Linux checkout:
Type of Change
Testing Performed
npm run check:pr— typecheck, lint, formatting, Knip, metadata, build, 344 test files / 1,697 tests, TypeDoc, and generated-document checks passednpm pack --dry-run— 738 files, 1.1 MB packagenpm run check:fast— typecheck and lint passednpm run verify:package— package construction and startup checks ran until the Linux Hopper platform probe; this host lacks Xvfb, so the verifier stopped withmissing_xvfbThe exact-diff review was stopped at the explicit publish request after one clean bounded pass; no actionable finding had been reported.
Tool Contract Impact
None. The canonical tool inventory and generated catalog are unchanged.
Suggested review order
vitest.config.ts,docs/testing.md, and the process-global lane classifier.src/domain,src/application, and provider directories.Related Issues
No linked issue.