Add quic support#15
Conversation
robertsLando
left a comment
robertsLando
left a comment
There was a problem hiding this comment.
Fix lint issues. Also could you submit a test for that?
|
Added support for QUIC protocol through the core QUIC module of NodeJS (v15 - pre) Builds pass only with the NodeJS 15 pre version (manual build) currently. |
getlarge
left a comment
getlarge
left a comment
There was a problem hiding this comment.
@agilan2001 Like @robertsLando said, we should have some tests to check that it works.
The problem is that QUIC seems to be only supported on Node 15 with a custom build, right ?
So i wonder how that would fit in the current tests and the CI workflow, maybe with an environment variable ?
| server = createQuicSocket({ | ||
| endpoint: { port: options.quic.port || 8885 }, // default port 8885 if not mentioned in options | ||
| server: { | ||
| key: options.quic.key, | ||
| cert: options.quic.cert, | ||
| alpn: options.quic.alpn || 'mqtt' | ||
| } | ||
| }) |
There was a problem hiding this comment.
When i look at the Node15 API doc, there are a lot more options available, why did you ignore them ?
| http2?: Http2ServerOptions; | ||
| tls?: TlsOptions; | ||
| tcp?: { allowHalfOpen?: boolean; pauseOnConnect?: boolean }; | ||
| quic?:{ port?: number; key: ArrayBuffer; cert: ArrayBuffer; alpn: string}; |
There was a problem hiding this comment.
Are you sure, only ArrayBuffer is allowed for key and cert ?
|
About tests I would check node major using |
mcollina
left a comment
mcollina
left a comment
There was a problem hiding this comment.
I'm -1 to add this. The QUIC implementation is coming back to Node.js in the next month or so, let's wait for it.
|
@mcollina Is there any problem if we allow it only on allowed nodejs versions? |
|
There are no nodejs binaries with quic enabled. |
4 participants
Added support for QUIC protocol through the core QUIC module of NodeJS (v15 - pre)
NodeJS QUIC Documentation