Skip to content

Add quic support #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
agilan2001 wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Add quic support #15

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e912227
create quic socket
agilan2001 Jul 1, 2021
754dac5
quic type
agilan2001 Jul 1, 2021
92a4fd3
remove blank lines
agilan2001 Jul 1, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,24 @@ const createServer = (aedes, options = {}) => {
stream._socket = conn._socket
bindConnection(aedes, options, stream, req)
})
} else if (options.quic) {
const { createQuicSocket } = require('net')

server = createQuicSocket({
endpoint: { port: options.quic.port || 8885 }, // default port 8885 if not mentioned in options
server: {
key: options.quic.key,
cert: options.quic.cert,
alpn: options.quic.alpn || 'mqtt'
}
})
Comment on lines +73 to +80
Copy link
Copy Markdown
Member

@getlarge getlarge Jul 2, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When i look at the Node15 API doc, there are a lot more options available, why did you ignore them ?


server.on('session', (session) => {
session.on('stream', (stream) => {
stream.socket = session.socket
bindConnection(aedes, options, stream)
})
})
} else {
server = net.createServer((conn) => {
bindConnection(aedes, options, conn)
Expand Down
1 change: 1 addition & 0 deletions types/index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ export interface ServerFactoryOptions {
http2?: Http2ServerOptions;
tls?: TlsOptions;
tcp?: { allowHalfOpen?: boolean; pauseOnConnect?: boolean };
quic?:{ port?: number; key: ArrayBuffer; cert: ArrayBuffer; alpn: string};
Copy link
Copy Markdown
Member

@getlarge getlarge Jul 2, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure, only ArrayBuffer is allowed for key and cert ?

serverFactory?: ServerFactory;
protocolDecoder?: ProtocolDecoder;
extractSocketDetails?: ExtractSocketDetails;
Expand Down