Feature#379 메인페이지 제휴사 캐러셀 이미지 변경 #380
Conversation
WalkthroughRemoves the mosu-overlay package (code, types, README, tsconfig, package.json), removes mosu-utils and mosu-services package manifests and a tsconfig, prunes root scripts for overlay/form, and updates one image import in mosu-app ReviewSection.tsx. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Assessment against linked issues
Assessment against linked issues: Out-of-scope changes
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Tip 🔌 Remote MCP (Model Context Protocol) integration is now available!Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats. ✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
📦 Package 변경사항
📝 추가 및 변경된 파일총 3개 파일 변경 |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
mosu-app/src/widgets/home/ReviewSection.tsx (1)
195-203: Fix reverse tabnabbing: add noopener/noreferrer to window.open.Opening external links with
_blankwithoutnoopenerallows the new page to accesswindow.opener.Apply:
- onClick={() => item.href && window.open(item.href, "_blank")} + onClick={() => item.href && window.open(item.href, "_blank", "noopener,noreferrer")}
🧹 Nitpick comments (1)
mosu-app/src/widgets/home/ReviewSection.tsx (1)
200-201: More descriptive alt text per partner.Consider passing alt per item to improve accessibility and SEO.
Example:
- alt="제휴처" + alt={item.alt ?? "제휴처"}…and extend
PartnershipCarouselPropsaccordingly.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
⛔ Files ignored due to path filters (10)
mosu-app/src/widgets/home/assets/carousel-2.jpegis excluded by!**/*.jpegmosu-overlay/dist/hooks/useOverlay.d.tsis excluded by!**/dist/**mosu-overlay/dist/hooks/useOverlay.d.ts.mapis excluded by!**/dist/**,!**/*.mapmosu-overlay/dist/hooks/useOverlay.jsis excluded by!**/dist/**mosu-overlay/dist/index.d.tsis excluded by!**/dist/**mosu-overlay/dist/index.d.ts.mapis excluded by!**/dist/**,!**/*.mapmosu-overlay/dist/index.jsis excluded by!**/dist/**mosu-overlay/dist/types/types.d.tsis excluded by!**/dist/**mosu-overlay/dist/types/types.d.ts.mapis excluded by!**/dist/**,!**/*.mapmosu-overlay/dist/types/types.jsis excluded by!**/dist/**
📒 Files selected for processing (11)
mosu-app/src/widgets/home/ReviewSection.tsx(1 hunks)mosu-overlay/README.md(0 hunks)mosu-overlay/package.json(0 hunks)mosu-overlay/src/hooks/useOverlay.tsx(0 hunks)mosu-overlay/src/index.ts(0 hunks)mosu-overlay/src/types/types.ts(0 hunks)mosu-overlay/tsconfig.json(0 hunks)mosu-services/package.json(0 hunks)mosu-utils/package.json(0 hunks)mosu-utils/tsconfig.json(0 hunks)package.json(1 hunks)
💤 Files with no reviewable changes (9)
- mosu-overlay/tsconfig.json
- mosu-overlay/package.json
- mosu-utils/tsconfig.json
- mosu-overlay/src/index.ts
- mosu-overlay/src/hooks/useOverlay.tsx
- mosu-utils/package.json
- mosu-overlay/src/types/types.ts
- mosu-overlay/README.md
- mosu-services/package.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Run DangerJS
🔇 Additional comments (1)
package.json (1)
15-15: No stale overlay/form references remain. CI, docs, and code contain no imports or packages for@mosu/overlayor@mosu/form. Theconcurrentlydependency is still in use inpackage.json.
|
|
||
| import imgCarousel1 from "@/widgets/home/assets/carousel-1.jpeg"; | ||
| import imgCarousel2 from "@/widgets/home/assets/carousel-2.png"; | ||
| import imgCarousel2 from "@/widgets/home/assets/carousel-2.jpeg"; |
There was a problem hiding this comment.
💡 Verification agent
🧩 Analysis chain
JPEG import change looks fine; verify asset and purge stale references.
Switching from PNG to JPEG is OK with Next/Image. Please confirm the new file exists in the repo and that no code references the old carousel-2.png.
Run:
🏁 Script executed:
#!/bin/bash
# Ensure new asset exists and old refs are gone
fd -a 'carousel-2\.(jpeg|jpg|png)' mosu-app/src/widgets/home/assets -x ls -l
rg -nP 'carousel-2\.(png|jpeg|jpg)' -g 'mosu-app/**'Length of output: 483
Remove unused carousel-2.png asset
Delete mosu-app/src/widgets/home/assets/carousel-2.png; the code now imports carousel-2.jpeg and there are no remaining .png references.
🤖 Prompt for AI Agents
In mosu-app/src/widgets/home/ReviewSection.tsx around line 5, the repository
still contains an unused asset file
mosu-app/src/widgets/home/assets/carousel-2.png while the code imports
carousel-2.jpeg; remove the redundant PNG file from the assets directory (delete
mosu-app/src/widgets/home/assets/carousel-2.png) and ensure no other code
references the .png; if any stray references exist, update them to the .jpeg or
remove them.
📚 Storybook이 Chromatic에 배포되었습니다!
|
✅ Linked Issue
🔍 What I did
Summary by CodeRabbit
Chores
Documentation
No user-facing features or behavior changes are introduced in this release.