Skip to content

Conversation

@toothlessdev
Copy link
Member

@toothlessdev toothlessdev commented Sep 9, 2025

✅ Linked Issue

Summary by CodeRabbit

  • New Features

    • Added a top navigation item linking to the School Competition page.
    • Introduced a D-Day promotional section in the competition footer with highlighted date and messaging.
    • Updated the notice list with a new rule for tie-breaking based on number of applicants.
  • Refactor

    • Temporarily hid ranking sections on the competition page; overall layout remains unchanged.
  • Style

    • Added new responsive styles for the competition footer, including highlighted text and improved typography.

@toothlessdev toothlessdev self-assigned this Sep 9, 2025
@coderabbitai
Copy link

coderabbitai bot commented Sep 9, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

Adds a new top nav item for the competition page, disables rank sections on the competition page while keeping data fetching unchanged, updates the competition footer content and styles, and appends a new notice item.

Changes

Cohort / File(s) Summary of changes
Site Navigation
mosu-app/src/apps/site.ts
Prepends navTop item: label "학교 대항전", href "/events/competition". No other config changes.
Competition Page Layout
mosu-app/src/pages/events/competition/index.tsx
Comments out RankListSection/RankTableSection imports and JSX. Page component stops using props (keeps type). getStaticProps unchanged (still returns top3Schools/topRatedSchools).
Competition Footer (UI + Styles)
mosu-app/src/widgets/competition/*
SCSS: adds .footer_section__dday and .footer_section__dday__highlight with responsive typography. TSX: replaces previous title block with new D-Day promotional block; adds one notice bullet; sharing logic unchanged.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested labels

기능 구현, 도메인 : 이벤트

Suggested reviewers

  • kimgho

Poem

A hop, a skip—D-Day draws near!
I drum my paws: “토요일!” loud and clear.
Share the news, let rankings brew,
One chick(en) each for me and you.
New nav shines, the footer sings—
Onward, schools, flap joyful wings! 🐇🍗

Tip

👮 Agentic pre-merge checks are now available in preview!

Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.

  • Built-in checks – Quickly apply ready-made checks to enforce title conventions, require pull request descriptions that follow templates, validate linked issues for compliance, and more.
  • Custom agentic checks – Define your own rules using CodeRabbit’s advanced agentic capabilities to enforce organization-specific policies and workflows. For example, you can instruct CodeRabbit’s agent to verify that API documentation is updated whenever API schema files are modified in a PR. Note: Upto 5 custom checks are currently allowed during the preview period. Pricing for this feature will be announced in a few weeks.

Example:

reviews:
  pre_merge_checks:
    custom_checks:
      - name: "Undocumented Breaking Changes"
        mode: "warning"
        instructions: |
          Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).

Please share your feedback with us on this Discord post.


📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 4cacec8 and 0f23218.

📒 Files selected for processing (4)
  • mosu-app/src/apps/site.ts (1 hunks)
  • mosu-app/src/pages/events/competition/index.tsx (3 hunks)
  • mosu-app/src/widgets/competition/FooterSection.module.scss (1 hunks)
  • mosu-app/src/widgets/competition/FooterSection.tsx (2 hunks)
✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feature#388

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@toothlessdev toothlessdev moved this to 진행중 in mosu-client Sep 9, 2025
@toothlessdev toothlessdev merged commit 07a1653 into main Sep 9, 2025
4 of 6 checks passed
@toothlessdev toothlessdev deleted the feature#388 branch September 9, 2025 15:27
@github-project-automation github-project-automation bot moved this from 진행중 to 완료 in mosu-client Sep 9, 2025
@vercel
Copy link

vercel bot commented Sep 9, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
mosu-client Building Building Preview Comment Sep 9, 2025 3:28pm

@github-actions
Copy link

github-actions bot commented Sep 9, 2025

Warnings
⚠️ PR에 Reviewers가 지정되어 있지 않습니다. 리뷰어를 지정해주세요.
Messages
📖 ✅ PR 제목에 이슈 번호가 포함되어 있습니다.
📖 ✅ PR에 라벨이 지정되어 있습니다.
📖 ✅ PR에 Assignees가 지정되어 있습니다.
📖 ✅ package.json에 변경사항이 없습니다.
📖 ✅ 브랜치 이름 'feature#388'이 컨벤션을 따릅니다.
📖 ✅ TypeScript 컴파일이 성공적으로 완료되었습니다.
📖 ✅ ESLint 검사 결과 문제가 없습니다.

📝 추가 및 변경된 파일

총 4개 파일 변경

└── 📂 mosu-app/
    └── 📂 src/
        ├── 📂 apps/
        │   └── 📘 site.ts
        ├── 📂 pages/
        │   └── 📂 events/
        │       └── 📂 competition/
        │           └── ⚛️ index.tsx
        └── 📂 widgets/
            └── 📂 competition/
                ├── 📄 FooterSection.module.scss
                └── ⚛️ FooterSection.tsx

Generated by 🚫 dangerJS against 0f23218

@github-actions
Copy link

github-actions bot commented Sep 9, 2025

📚 Storybook이 Chromatic에 배포되었습니다!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: 완료

Development

Successfully merging this pull request may close these issues.

2 participants