Skip to content

Add ruff flake8-pytest-style rules#1369

Merged
shaunagm merged 32 commits intomove-coop:mainfrom
bmos:flake8-pytest-style
Sep 16, 2025
Merged

Add ruff flake8-pytest-style rules#1369
shaunagm merged 32 commits intomove-coop:mainfrom
bmos:flake8-pytest-style

Conversation

@bmos
Copy link
Contributor

@bmos bmos commented Mar 21, 2025

https://docs.astral.sh/ruff/rules/#flake8-pytest-style-pt

These ruff rules handle best practices and mistakes relating to pytest use.

58f8002 especially should make our tests much more resilient to false positives.

@bmos bmos force-pushed the flake8-pytest-style branch from 1351fd3 to 58f8002 Compare March 22, 2025 03:34
@bmos bmos marked this pull request as ready for review March 22, 2025 03:35
@github-actions
Copy link

github-actions bot commented Mar 22, 2025

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  parsons/box
  box.py 240-241, 318-319
  parsons/capitol_canary
  capitol_canary.py
  parsons/donorbox
  donorbox.py
  parsons/etl
  table.py
  parsons/nation_builder
  nation_builder.py
  parsons/ngpvan
  people.py
  scores.py
  parsons/notifications
  sendmail.py
  parsons/targetsmart
  targetsmart_api.py
  targetsmart_automation.py 213-215
Project Total  

This report was generated by python-coverage-comment-action

@bmos bmos force-pushed the flake8-pytest-style branch 2 times, most recently from f695ffc to 57e18e8 Compare April 27, 2025 00:19
@bmos bmos force-pushed the flake8-pytest-style branch 2 times, most recently from 9800437 to 58f8002 Compare June 12, 2025 17:30
@bmos bmos marked this pull request as draft June 12, 2025 22:15
@bmos bmos marked this pull request as ready for review June 26, 2025 19:34
@bmos bmos force-pushed the flake8-pytest-style branch from 3c57215 to 8d5c890 Compare July 4, 2025 01:05
Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ruff found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.

@shaunagm shaunagm merged commit ec8fb23 into move-coop:main Sep 16, 2025
84 checks passed
@bmos bmos deleted the flake8-pytest-style branch September 22, 2025 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants