Skip to content

Conversation

@DLu
Copy link
Contributor

@DLu DLu commented May 8, 2025

As of the ROS 2 Kilted release ament_target_dependencies is deprecated.

This PR updates the syntax. Caution should be used to ensure that the target branch is not used for other ROS 2 distros.

Note: This PR was generated by a bot script, but using the simple pattern matching of the ros_glint library. No LLMs were used.

@DLu
Copy link
Contributor Author

DLu commented May 9, 2025

Note: This doesn't fully compile for me. I'm not sure if random_numbers is missing an export.

@rhaschke
Copy link
Contributor

Note: This doesn't fully compile for me. I'm not sure if random_numbers is missing an export.

You explicitly commented out random_numbers. Why?

@DLu
Copy link
Contributor Author

DLu commented May 12, 2025

As is, this is the result on my machine:

--- stderr: geometric_shapes
In file included from /media/bespin/Projects/ROS/ros2_dee2/ros2_ws/src/geometric_shapes/include/geometric_shapes/body_operations.h:35,
                 from /media/bespin/Projects/ROS/ros2_dee2/ros2_ws/src/geometric_shapes/src/body_operations.cpp:31:
/media/bespin/Projects/ROS/ros2_dee2/ros2_ws/src/geometric_shapes/include/geometric_shapes/bodies.h:39:10: fatal error: random_numbers/random_numbers.h: No such file or directory
   39 | #include <random_numbers/random_numbers.h>
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.

With the random numbers line uncommented,

--- stderr: geometric_shapes
CMake Error at CMakeLists.txt:94 (target_link_libraries):
  Target "geometric_shapes" links to:

    random_numbers::random_numbers

  but the target was not found.  Possible reasons include:

    * There is a typo in the target name.
    * A find_package call is missing for an IMPORTED target.
    * An ALIAS target is missing.

With moveit/random_numbers#47

--- stderr: random_numbers
/usr/bin/ld: cannot find -lBoost: No such file or directory

@rhaschke rhaschke mentioned this pull request Jun 6, 2025
@rhaschke
Copy link
Contributor

rhaschke commented Jun 6, 2025

Correctly fixed via #262 and moveit/random_numbers@e16611a

@rhaschke rhaschke closed this Jun 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants