Skip to content

[kilted] Update deprecated call to ament_target_dependencies #259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

[kilted] Update deprecated call to ament_target_dependencies #259

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9b0656c
[kilted] Update deprecated call to ament_target_dependencies
DLu May 8, 2025
ed80159
Combine target_link_libraries
DLu May 8, 2025
7958f80
Fix targets
DLu May 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 14 additions & 4 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,11 +90,21 @@ target_compile_options(${PROJECT_NAME} PRIVATE ${PROJECT_COMPILE_OPTIONS})
target_include_directories(${PROJECT_NAME}
PUBLIC $<BUILD_INTERFACE:${CMAKE_CURRENT_SOURCE_DIR}/include>
$<INSTALL_INTERFACE:include/${PROJECT_NAME}>)
ament_target_dependencies(${PROJECT_NAME} PUBLIC
${THIS_PACKAGE_EXPORT_DEPENDS}
)
# Private libraries that are not transitively needed by downstream projects
target_link_libraries(${PROJECT_NAME} PRIVATE assimp::assimp fcl ${QHULL_LIBRARIES})
target_link_libraries(${PROJECT_NAME}
PRIVATE
assimp::assimp
fcl
${QHULL_LIBRARIES}
PUBLIC
${geometry_msgs_TARGETS}
${shape_msgs_TARGETS}
${visualization_msgs_TARGETS}
eigen_stl_containers::eigen_stl_containers
# random_numbers::random_numbers
rclcpp::rclcpp
resource_retriever::resource_retriever
)
target_include_directories(${PROJECT_NAME} PRIVATE ${QHULL_INCLUDE_DIRS})

if(BUILD_TESTING)
Expand Down
3 changes: 1 addition & 2 deletions test/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,7 @@ configure_file(resources/config.h.in "${CMAKE_CURRENT_BINARY_DIR}/resources/conf
include_directories(${CMAKE_CURRENT_BINARY_DIR})

ament_add_gtest(test_basics test_basics.cpp)
target_link_libraries(test_basics ${PROJECT_NAME})
ament_target_dependencies(test_basics Eigen3)
target_link_libraries(test_basics ${PROJECT_NAME} Eigen3)

ament_add_gtest(test_point_inclusion test_point_inclusion.cpp)
target_link_libraries(test_point_inclusion ${PROJECT_NAME})
Expand Down
Loading