Fix TrajectoryExecutionManager rejecting unrecognized parameters#3689
Open
PierceCoyle wants to merge 1 commit intomoveit:mainfrom
Open
Fix TrajectoryExecutionManager rejecting unrecognized parameters#3689PierceCoyle wants to merge 1 commit intomoveit:mainfrom
PierceCoyle wants to merge 1 commit intomoveit:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The
on_set_parameters_callbackinTrajectoryExecutionManager::initialize()has an else block that rejects all parameters that it doesn't recognize. This crashes MoveItPy withuse_sim_time = True, resulting in the error message:The else block itself seems to be an anti-pattern mentioned in the comments of rclcpp's node.hpp.
Tested on ROS2 Jazzy, Ubuntu 24.04.
Resolves #2940
Related #2220, ros2/rclcpp#1587
Checklist