Skip to content

Ability to set a robot_description that is not within the drake_models package #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 4, 2025

Conversation

DaniGarciaLopez
Copy link
Contributor

Addresses #68

Example of usage

Add the following in drake_ktopt_planning.yaml:

base_frame: ""
external_robot_description: ["/home/user/xarm_ws/src/xarm_ros2/xarm_description"]

Copy link
Member

@kamiradi kamiradi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR,

Could you add a section in the readme with your example usage. Your PR message should be just fine. Also, follow the pre-commit steps so that the formatting is in order.

Thanks!

@DaniGarciaLopez
Copy link
Contributor Author

Thanks for reviewing! Not sure where was the best place to add it. What about something like that?

Copy link
Member

@kamiradi kamiradi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup,

This looks good for now.

@kamiradi kamiradi merged commit db5f3c1 into moveit:main Mar 4, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants